Skip to content

Add HeaderCollection annotation, more cleanup#130

Merged
RikkiGibson merged 2 commits into
runtime-v2from
daschult/HeaderCollectionAnnotation
Feb 10, 2018
Merged

Add HeaderCollection annotation, more cleanup#130
RikkiGibson merged 2 commits into
runtime-v2from
daschult/HeaderCollectionAnnotation

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 10, 2018

No description provided.

@ghost ghost requested a review from RikkiGibson February 10, 2018 00:57
@ghost ghost added the in progress label Feb 10, 2018
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 10, 2018

@RikkiGibson I checked this against the storage repository and the generated code compiles properly. Once this pull request is merged, we can do another release and storage should be good to go.

@olydis
Copy link
Copy Markdown

olydis commented Feb 10, 2018

🤖 AutoRest automatic feature coverage report 🤖

feature set version 2.3.14

❌️ General: 92%

40 out of 522 features are not covered by tests

ConstantsInBody, ConstantsInPath, FileStreamVeryLarge, FormdataStreamUploadFile, HttpRedirect300Get, HttpRedirect300Head, HttpRedirect301Get, HttpRedirect301Put, HttpRedirect302Get, HttpRedirect302Head, HttpRedirect302Patch, HttpRedirect303Post, HttpRedirect307Delete, HttpRedirect307Get, HttpRedirect307Head, HttpRedirect307Patch, HttpRedirect307Post, HttpRedirect307Put, ResponsesScenarioC200MatchingModel, ResponsesScenarioC201MatchingModel, ResponsesScenarioC404MatchingModel, StreamUploadFile, UrlPathsArrayCSVInPath, UrlQueriesArrayMultiEmpty, UrlQueriesArrayMultiNull, UrlQueriesArrayMultiValid, allowedValueEnum, expectedEnum, getByteEmpty, getByteInvalid, getComplexPolymorphismComplicated, getEnumReferenced, getEnumReferencedConstant, getStringMultiByteCharacters, putComplexPolymorphismComplicated, putEnumReferenced, putEnumReferencedConstant, putStringMultiByteCharacters, roundTripEnum, unexpectedEnum

❌️ Azure: 88%

14 out of 118 features are not covered by tests

AzureMethodQueryUrlEncoding, AzureODataFilter, AzurePathQueryUrlEncoding, AzureRequestClientIdInError, AzureSwaggerQueryUrlEncoding, AzureXmsCustomNamedRequestId, AzureXmsCustomNamedRequestIdParameterGroup, AzureXmsRequestClientIdNull, CustomHeaderPostAsyncSucceded, CustomHeaderPostSucceeded, CustomHeaderPutAsyncSucceded, CustomHeaderPutSucceeded, LRONonRetryPut201Creating400InvalidJson, PagingOdataMultiple

Copy link
Copy Markdown
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great--like the way you've composed together the different parts of method generation

@RikkiGibson RikkiGibson merged commit 381ecd3 into runtime-v2 Feb 10, 2018
@RikkiGibson RikkiGibson deleted the daschult/HeaderCollectionAnnotation branch February 10, 2018 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants