Use JsonProperty for non-attribute members in XML models#137
Merged
Conversation
ghost
approved these changes
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression related to headers serialization. When you use
@JacksonXmlProperty, the attribute values are ignored for JSON serialization, but when you use@JsonProperty, the attribute values are also used for XML serialization.Since we do JSON serialization internally to translate to Headers classes, we weren't serializing using the correct header names, and we would always produce a Headers object with null for every property.
This fix was only tested manually against a Blob Service Swagger because it's been requested that this fix be deployed ASAP.