eng, script to exclude re-gen of v2 lib

.github/copilot-instructions.md

@@ -4,7 +4,7 @@ Steps:
 
 1. In "core" folder, run `git pull upstream main` to fetch latest commit from upstream or origin.
 2. Go back to project root (`cd ..`). Commit the change in "core" folder.
-3. Run `ncu -u` on "package.json" in both "package.json" from "typespec-extension" and "typespec-tests" folder.
+3. Run `ncu -u -x @typescript-eslint/eslint-plugin` on "package.json" in both "package.json" from "typespec-extension" and "typespec-tests" folder.
 4. Update package versions in `peerDependencies` (keep the semver range) in "package.json" from "typespec-extension" folder, according to the corresponding package versions in `devDependencies`.
 5. Update package versions in `override` (keep the semver range) in "package.json" from "typespec-tests" folder, according to the corresponding package versions in "package.json" from "typespec-extension" folder.
 6. Save the files, and run `npm install` in "typespec-extension" folder, so that "package-lock.json" would be updated.

azure-dataplane-tests/src/main/java/com/azure/ai/formrecognizer/documentanalysis/implementation/FormRecognizerClientImplBuilder.java

@@ -32,6 +32,7 @@
 import com.azure.core.util.Configuration;
 import com.azure.core.util.CoreUtils;
 import com.azure.core.util.builder.ClientBuilderUtil;
+import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 import java.util.ArrayList;
@@ -95,6 +96,9 @@ public FormRecognizerClientImplBuilder httpClient(HttpClient httpClient) {
     @Generated
     @Override
     public FormRecognizerClientImplBuilder pipeline(HttpPipeline pipeline) {
+        if (this.pipeline != null && pipeline == null) {
+            LOGGER.atInfo().log("HttpPipeline is being set to 'null' when it was previously configured.");
+        }
         this.pipeline = pipeline;
         return this;
     }
@@ -321,4 +325,6 @@ private HttpPipeline createHttpPipeline() {
             .build();
         return httpPipeline;
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(FormRecognizerClientImplBuilder.class);
 }

azure-tests/src/main/java/fixtures/azureparametergrouping/AutoRestParameterGroupingTestServiceBuilder.java

@@ -28,6 +28,7 @@
 import com.azure.core.util.Configuration;
 import com.azure.core.util.CoreUtils;
 import com.azure.core.util.builder.ClientBuilderUtil;
+import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 import java.util.ArrayList;
@@ -91,6 +92,9 @@ public AutoRestParameterGroupingTestServiceBuilder httpClient(HttpClient httpCli
     @Generated
     @Override
     public AutoRestParameterGroupingTestServiceBuilder pipeline(HttpPipeline pipeline) {
+        if (this.pipeline != null && pipeline == null) {
+            LOGGER.atInfo().log("HttpPipeline is being set to 'null' when it was previously configured.");
+        }
         this.pipeline = pipeline;
         return this;
     }
@@ -281,4 +285,6 @@ private HttpPipeline createHttpPipeline() {
             .build();
         return httpPipeline;
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(AutoRestParameterGroupingTestServiceBuilder.class);
 }

azure-tests/src/main/java/fixtures/azureparametergrouping/models/ParameterGroupingPostRequiredParameters.java

@@ -6,6 +6,7 @@
 
 import com.azure.core.annotation.Fluent;
 import com.azure.core.annotation.Generated;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Parameter group.
@@ -138,8 +139,11 @@ public ParameterGroupingPostRequiredParameters setBody(int body) {
      */
     public void validate() {
         if (getPath() == null) {
-            throw new IllegalArgumentException(
-                "Missing required property path in model ParameterGroupingPostRequiredParameters");
+            throw LOGGER.atError()
+                .log(new IllegalArgumentException(
+                    "Missing required property path in model ParameterGroupingPostRequiredParameters"));
         }
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(ParameterGroupingPostRequiredParameters.class);
 }

azure-tests/src/main/java/fixtures/azurereport/AutoRestReportServiceForAzureBuilder.java

@@ -28,6 +28,7 @@
 import com.azure.core.util.Configuration;
 import com.azure.core.util.CoreUtils;
 import com.azure.core.util.builder.ClientBuilderUtil;
+import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 import java.util.ArrayList;
@@ -90,6 +91,9 @@ public AutoRestReportServiceForAzureBuilder httpClient(HttpClient httpClient) {
     @Generated
     @Override
     public AutoRestReportServiceForAzureBuilder pipeline(HttpPipeline pipeline) {
+        if (this.pipeline != null && pipeline == null) {
+            LOGGER.atInfo().log("HttpPipeline is being set to 'null' when it was previously configured.");
+        }
         this.pipeline = pipeline;
         return this;
     }
@@ -280,4 +284,6 @@ private HttpPipeline createHttpPipeline() {
             .build();
         return httpPipeline;
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(AutoRestReportServiceForAzureBuilder.class);
 }

azure-tests/src/main/java/fixtures/azurespecials/AutoRestAzureSpecialParametersTestClientBuilder.java

@@ -28,6 +28,7 @@
 import com.azure.core.util.Configuration;
 import com.azure.core.util.CoreUtils;
 import com.azure.core.util.builder.ClientBuilderUtil;
+import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 import java.util.ArrayList;
@@ -91,6 +92,9 @@ public AutoRestAzureSpecialParametersTestClientBuilder httpClient(HttpClient htt
     @Generated
     @Override
     public AutoRestAzureSpecialParametersTestClientBuilder pipeline(HttpPipeline pipeline) {
+        if (this.pipeline != null && pipeline == null) {
+            LOGGER.atInfo().log("HttpPipeline is being set to 'null' when it was previously configured.");
+        }
         this.pipeline = pipeline;
         return this;
     }
@@ -321,4 +325,6 @@ private HttpPipeline createHttpPipeline() {
             .build();
         return httpPipeline;
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(AutoRestAzureSpecialParametersTestClientBuilder.class);
 }

azure-tests/src/main/java/fixtures/azurespecials/models/HeaderCustomNamedRequestIdParamGroupingParameters.java

@@ -6,6 +6,7 @@
 
 import com.azure.core.annotation.Fluent;
 import com.azure.core.annotation.Generated;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Parameter group.
@@ -54,8 +55,12 @@ public HeaderCustomNamedRequestIdParamGroupingParameters setFooClientRequestId(S
      */
     public void validate() {
         if (getFooClientRequestId() == null) {
-            throw new IllegalArgumentException(
-                "Missing required property fooClientRequestId in model HeaderCustomNamedRequestIdParamGroupingParameters");
+            throw LOGGER.atError()
+                .log(new IllegalArgumentException(
+                    "Missing required property fooClientRequestId in model HeaderCustomNamedRequestIdParamGroupingParameters"));
         }
     }
+
+    private static final ClientLogger LOGGER
+        = new ClientLogger(HeaderCustomNamedRequestIdParamGroupingParameters.class);
 }

azure-tests/src/main/java/fixtures/custombaseuri/paging/AutoRestParameterizedHostTestPagingClientBuilder.java

@@ -28,6 +28,7 @@
 import com.azure.core.util.Configuration;
 import com.azure.core.util.CoreUtils;
 import com.azure.core.util.builder.ClientBuilderUtil;
+import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 import java.util.ArrayList;
@@ -91,6 +92,9 @@ public AutoRestParameterizedHostTestPagingClientBuilder httpClient(HttpClient ht
     @Generated
     @Override
     public AutoRestParameterizedHostTestPagingClientBuilder pipeline(HttpPipeline pipeline) {
+        if (this.pipeline != null && pipeline == null) {
+            LOGGER.atInfo().log("HttpPipeline is being set to 'null' when it was previously configured.");
+        }
         this.pipeline = pipeline;
         return this;
     }
@@ -281,4 +285,6 @@ private HttpPipeline createHttpPipeline() {
             .build();
         return httpPipeline;
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(AutoRestParameterizedHostTestPagingClientBuilder.class);
 }

azure-tests/src/main/java/fixtures/paging/AutoRestPagingTestServiceBuilder.java

@@ -28,6 +28,7 @@
 import com.azure.core.util.Configuration;
 import com.azure.core.util.CoreUtils;
 import com.azure.core.util.builder.ClientBuilderUtil;
+import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 import fixtures.paging.implementation.AutoRestPagingTestServiceImpl;
@@ -92,6 +93,9 @@ public AutoRestPagingTestServiceBuilder httpClient(HttpClient httpClient) {
     @Generated
     @Override
     public AutoRestPagingTestServiceBuilder pipeline(HttpPipeline pipeline) {
+        if (this.pipeline != null && pipeline == null) {
+            LOGGER.atInfo().log("HttpPipeline is being set to 'null' when it was previously configured.");
+        }
         this.pipeline = pipeline;
         return this;
     }
@@ -321,4 +325,6 @@ public AutoRestPagingTestServiceAsyncClient buildAsyncClient() {
     public AutoRestPagingTestServiceClient buildClient() {
         return new AutoRestPagingTestServiceClient(buildInnerClient().getPagings());
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(AutoRestPagingTestServiceBuilder.class);
 }

azure-tests/src/main/java/fixtures/paging/models/CustomParameterGroup.java

@@ -6,6 +6,7 @@
 
 import com.azure.core.annotation.Fluent;
 import com.azure.core.annotation.Generated;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Parameter group.
@@ -82,10 +83,15 @@ public CustomParameterGroup setTenant(String tenant) {
      */
     public void validate() {
         if (getApiVersion() == null) {
-            throw new IllegalArgumentException("Missing required property apiVersion in model CustomParameterGroup");
+            throw LOGGER.atError()
+                .log(
+                    new IllegalArgumentException("Missing required property apiVersion in model CustomParameterGroup"));
         }
         if (getTenant() == null) {
-            throw new IllegalArgumentException("Missing required property tenant in model CustomParameterGroup");
+            throw LOGGER.atError()
+                .log(new IllegalArgumentException("Missing required property tenant in model CustomParameterGroup"));
         }
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(CustomParameterGroup.class);
 }

azure-tests/src/main/java/fixtures/subscriptionidapiversion/MicrosoftAzureTestUrlBuilder.java

@@ -28,6 +28,7 @@
 import com.azure.core.util.Configuration;
 import com.azure.core.util.CoreUtils;
 import com.azure.core.util.builder.ClientBuilderUtil;
+import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 import java.util.ArrayList;
@@ -90,6 +91,9 @@ public MicrosoftAzureTestUrlBuilder httpClient(HttpClient httpClient) {
     @Generated
     @Override
     public MicrosoftAzureTestUrlBuilder pipeline(HttpPipeline pipeline) {
+        if (this.pipeline != null && pipeline == null) {
+            LOGGER.atInfo().log("HttpPipeline is being set to 'null' when it was previously configured.");
+        }
         this.pipeline = pipeline;
         return this;
     }
@@ -318,4 +322,6 @@ private HttpPipeline createHttpPipeline() {
             .build();
         return httpPipeline;
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(MicrosoftAzureTestUrlBuilder.class);
 }

customization-tests/src/main/java/fixtures/bodycomplex/AutoRestComplexTestServiceBuilder.java

@@ -28,6 +28,7 @@
 import com.azure.core.util.Configuration;
 import com.azure.core.util.CoreUtils;
 import com.azure.core.util.builder.ClientBuilderUtil;
+import com.azure.core.util.logging.ClientLogger;
 import com.azure.core.util.serializer.JacksonAdapter;
 import com.azure.core.util.serializer.SerializerAdapter;
 import fixtures.bodycomplex.implementation.AutoRestComplexTestServiceImpl;
@@ -110,6 +111,9 @@ public AutoRestComplexTestServiceBuilder httpClient(HttpClient httpClient) {
     @Generated
     @Override
     public AutoRestComplexTestServiceBuilder pipeline(HttpPipeline pipeline) {
+        if (this.pipeline != null && pipeline == null) {
+            LOGGER.atInfo().log("HttpPipeline is being set to 'null' when it was previously configured.");
+        }
         this.pipeline = pipeline;
         return this;
     }
@@ -499,4 +503,6 @@ public ReadonlypropertyClient buildReadonlypropertyClient() {
     public FlattencomplexClient buildFlattencomplexClient() {
         return new FlattencomplexClient(buildInnerClient().getFlattencomplexes());
     }
+
+    private static final ClientLogger LOGGER = new ClientLogger(AutoRestComplexTestServiceBuilder.class);
 }

eng/sdk/sync_sdk.py

@@ -20,7 +20,6 @@
     # expect failure on below
     # "azure-developer-devcenter",  # 2 breaks introduced into stable api-version
     # "azure-ai-vision-face",  # SDK in development
-    # "azure-health-insights-radiologyinsights",  # SDK in development
 ]
 
 
@@ -111,6 +110,11 @@ def update_sdks():
         if artifact in skip_artifacts:
             continue
 
+        if os.path.dirname(module_path).endswith("-v2"):
+            # skip modules on azure-core-v2
+            logging.info(f"Skip azure-core-v2 module on path {module_path}")
+            continue
+
         generated_samples_path = os.path.join(
             module_path, get_generated_folder_from_artifact(module_path, artifact, "samples")
         )

fluent-tests/src/test/java/com/azure/mgmttest/CompilationTests.java

@@ -29,8 +29,6 @@
 import com.azure.mgmttest.nonstringexpandableenum.fluent.models.ScheduledQueryRuleProperties;
 import com.azure.mgmttest.nonstringexpandableenum.models.AlertSeverity;
 import com.azure.mgmttest.postgresqlhsc.fluent.models.ServerConfigurationInner;
-import com.azure.mgmttest.resources.fluent.DeploymentsClient;
-import com.azure.mgmttest.resources.fluent.models.DeploymentExtendedInner;
 import com.azure.mgmttest.resources.fluent.models.ResourceGroupInner;
 import com.azure.mgmttest.resources.models.IdentityUserAssignedIdentities;
 import com.azure.mgmttest.resourcewithwritablename.fluent.models.FirewallRuleInner;
@@ -77,8 +75,6 @@ public void testInnerSupport() {
         storageAccounts.list();
 
         // Add InnerSupportsGet to class.
-        InnerSupportsGet<DeploymentExtendedInner> deployments = mock(DeploymentsClient.class);
-        deployments.getByResourceGroup(anyString(), anyString());
 
         InnerSupportsGet<NetworkInterfaceInner> networkInterfaces = mock(NetworkInterfacesClient.class);
         networkInterfaces.getByResourceGroup(anyString(), anyString());