Skip to content

Conversation

@msyyc
Copy link
Member

@msyyc msyyc commented Aug 16, 2022

@msyyc msyyc marked this pull request as ready for review August 17, 2022 06:17
Comment on lines +767 to +777
return {
type: credential_type,
optional: false,
description: "Credential needed for the client to connect to Azure.",
clientName: "credential",
location: "other",
restApiName: "credential",
implementation: "Client",
skipUrlEncoding: true,
inOverload: false
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we only support one kind of auth even if more kinds are defined.

credential_type = {
type: "OAuth2",
policy: {
type: "BearerTokenCredentialPolicy",
Copy link
Member Author

@msyyc msyyc Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't get info to distinguish BearerTokenCredentialPolicy and ARMChallengeAuthenticationPolicy. Maybe we can get it in sidecar in the future?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, we basically need sidecar / additional cadl improvements to know if something is --azure-arm or not. I think we can do BearerTokenCredentialPolicy for now, but ARM is blocked from using our CADL SDKs until we add this support.

cc @Azure/linux-sme

}
}
}
return undefined
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that the Prettier can't work although it doesn't influence running. I think we can configure some settings in .vscode to automatically format the code like cadl-azure.

@iscai-msft iscai-msft merged commit bb041fe into autorestv3 Aug 22, 2022
@iscai-msft iscai-msft deleted the cadl-python-security branch August 22, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants