Skip to content

Fix discriminator initialize #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 2 commits into from
Aug 1, 2024
Merged

Fix discriminator initialize #2737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7da112
fix initialize for discriminator model
msyyc Aug 1, 2024
e0cc0c4
changelog
msyyc Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-discriminator-initialize-2024-7-1-11-29-41.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@azure-tools/typespec-python"
---

Fix initialize for model which only has discriminator property
5 changes: 3 additions & 2 deletions packages/typespec-python/generator/pygen/codegen/templates/model_dpg.py.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
__flattened_items = ["{{ model.flattened_items|join('\", \"') }}"]
{% endif %}

{% if not model.internal and serializer.init_line(model) %}
{% set need_init = (not model.internal) and (serializer.init_line(model) or model.discriminator)%}
Copy link
Copy Markdown
Member Author

@msyyc msyyc Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For model which only has discriminator, we shall also generate __init__ otherwise initialization of model will report error.

{% if need_init %}
@overload
def __init__(
self,
Expand All @@ -64,7 +65,7 @@

{% endif %}
{% set initialize_properties = serializer.initialize_properties(model) %}
{% if not model.internal and serializer.init_line(model) or initialize_properties %}
{% if need_init or initialize_properties %}
def __init__(self, *args: Any, **kwargs: Any) -> None:{{ '# pylint: disable=useless-super-delegation' if not initialize_properties else '' }}
{% for line in serializer.super_call(model) %}
{{ line }}
Expand Down