Fix to get right response and exception#2756
Merged
iscai-msft merged 18 commits intomainfrom Aug 14, 2024
Merged
Conversation
msyyc
commented
Aug 8, 2024
msyyc
commented
Aug 8, 2024
msyyc
commented
Aug 8, 2024
| ): Record<string, any> { | ||
| return { | ||
| ...emitHttpOperation(context, rootClient, operationGroupName, method.operation), | ||
| ...emitHttpOperation(context, rootClient, operationGroupName, method.operation, method), |
Member
Author
There was a problem hiding this comment.
Python SDK always set response type of initial operation as Binary type so just keep it same as begin_xxx API.
msyyc
changed the title
msyyc
commented
Aug 8, 2024
Comment on lines
+333
to
+341
| if (isException) { | ||
| if (response.type && !isAzureCoreErrorResponse(response.type)) { | ||
| type = getType(context, response.type); | ||
| } | ||
| } else if (method && !method.kind.includes("basic")) { | ||
| if (method.response.type) { | ||
| type = getType(context, method.response.type); | ||
| } | ||
| } else if (response.type) { |
Member
Author
There was a problem hiding this comment.
- For exception response, need to filter Azure.Core.ErrorResponse
- For normal response, there are 2 kinds:
- lro/lropaging/paging API: there shall always be one kind of response type so use
method.response.typedirectly - basic API: there may be multi response types, so honor http response type.
msyyc
commented
Aug 8, 2024
| t | ||
| for t in self.types_map.values() | ||
| if isinstance(t, ModelType) and not (self.options["models_mode"] == "dpg" and t.page_result_model) | ||
| if isinstance(t, ModelType) and t.usage != UsageFlags.Default.value |
Member
Author
There was a problem hiding this comment.
Use usage to filter unneeded model.
iscai-msft
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2742 and #2769