Snake case naming optimization (with vendor code from @azure-tools/codegen)#2810
Merged
Snake case naming optimization (with vendor code from @azure-tools/codegen)#2810
@azure-tools/codegen)#2810Conversation
msyyc
changed the title
@azure-tools/codegen)
iscai-msft
reviewed
Sep 3, 2024
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
thanks for vendoring!
tadelesh
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2636
#2637 adopts
@azure-tools/codegenwhich is also adopted by m4 however the package is not maintained. After discussion, we don't plan to use it anymore. So this PR extract the core logic as vendor code for snake case naming.Here is the influence for existing packages Azure/azure-sdk-for-python@941ada1 and we can see most of changes are more visible in view of naming. And we can use
@clientNameto avoid breakings if needed.