Skip to content

Fix "line-too-long" for property of model #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 2 commits into from
Sep 12, 2024
Merged

Fix "line-too-long" for property of model #2837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33a321b
fix line-too-long for property of model
msyyc Sep 12, 2024
2e97d68
changelog
msyyc Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-pylint-2024-09-12-2024-8-12-16-9-4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@azure-tools/typespec-python"
---

Fix "line-too-long" for property of model
3 changes: 2 additions & 1 deletion packages/typespec-python/generator/pygen/codegen/serializers/model_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,10 @@ def declare_property(prop: Property) -> str:
else ""
)
generated_code = f'{prop.client_name}: {prop.type_annotation()} = {field}({", ".join(args)})'
# there is 4 spaces indentation so original line length limit 120 - 4 = 116
pylint_disable = (
" # pylint: disable=line-too-long"
if len(generated_code) <= 120 < (len(generated_code) + len(type_ignore))
if len(generated_code) <= 116 < (len(generated_code) + len(type_ignore))
Copy link
Copy Markdown
Member Author

@msyyc msyyc Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is 4 spaces indentation so original line length limit 120 - 4 = 116

else ""
)
return f"{generated_code}{type_ignore}{pylint_disable}"
Expand Down