Remove useless pylint disable comments

.chronus/changes/pylint-update-2024-9-18-11-28-35.md

@@ -0,0 +1,8 @@
+---
+changeKind: fix
+packages:
+  - "@autorest/python"
+  - "@azure-tools/typespec-python"
+---
+
+- Fix pylint issue for useless suppressions

eng/scripts/run_pylint.py

@@ -34,8 +34,11 @@ def _single_dir_pylint(mod):
                 "-m",
                 "pylint",
                 "--rcfile={}".format(get_rfc_file_location()),
+                "--evaluation=(max(0, 0 if fatal else 10.0 - ((float(5 * error + warning + refactor + convention + info)/ statement) * 10)))",
                 "--load-plugins=pylint_guidelines_checker",
                 "--output-format=parseable",
+                "--recursive=y",
+                "--py-version=3.8",
                 str(inner_class.absolute()),
             ]
         )
@@ -46,4 +49,7 @@ def _single_dir_pylint(mod):
 
 
 if __name__ == "__main__":
+    if sys.version_info >= (3, 9, 0):
+        # only run pylint with python 3.8
+        sys.exit(0)
     run_check("pylint", _single_dir_pylint, "Pylint")

packages/autorest.python/package.json

@@ -35,7 +35,7 @@
   },
   "devDependencies": {
     "@microsoft.azure/autorest.testserver": "^3.3.50",
-    "@typespec/http-client-python": "0.3.2",
+    "@typespec/http-client-python": "0.3.3",
     "chalk": "5.3.0",
     "typescript": "~5.1.6"
   },

packages/autorest.python/samples/specification/azure_key_credential/generated/azure/key/credential/sample/__init__.py

@@ -19,7 +19,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/azure_key_credential/generated/azure/key/credential/sample/_serialization.py

@@ -1,3 +1,4 @@
+# pylint: disable=too-many-lines
 # --------------------------------------------------------------------------
 #
 # Copyright (c) Microsoft Corporation. All rights reserved.

packages/autorest.python/samples/specification/azure_key_credential/generated/azure/key/credential/sample/aio/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/azure_key_credential/generated/azure/key/credential/sample/aio/operations/__init__.py

@@ -15,7 +15,7 @@
 from ._operations import HttpSuccessOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/azure_key_credential/generated/azure/key/credential/sample/operations/__init__.py

@@ -15,7 +15,7 @@
 from ._operations import HttpSuccessOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/basic/generated/azure/basic/sample/__init__.py

@@ -19,7 +19,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/basic/generated/azure/basic/sample/_serialization.py

@@ -1,3 +1,4 @@
+# pylint: disable=too-many-lines
 # --------------------------------------------------------------------------
 #
 # Copyright (c) Microsoft Corporation. All rights reserved.

packages/autorest.python/samples/specification/basic/generated/azure/basic/sample/aio/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/basic/generated/azure/basic/sample/aio/operations/__init__.py

@@ -15,7 +15,7 @@
 from ._operations import HttpSuccessOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/basic/generated/azure/basic/sample/operations/__init__.py

@@ -15,7 +15,7 @@
 from ._operations import HttpSuccessOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/directives/generated/azure/directives/sample/__init__.py

@@ -19,7 +19,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/directives/generated/azure/directives/sample/_operations/__init__.py

@@ -15,7 +15,7 @@
 from ._operations import PollingPagingExampleOperationsMixin
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/directives/generated/azure/directives/sample/_serialization.py

@@ -1,3 +1,4 @@
+# pylint: disable=too-many-lines
 # --------------------------------------------------------------------------
 #
 # Copyright (c) Microsoft Corporation. All rights reserved.

packages/autorest.python/samples/specification/directives/generated/azure/directives/sample/aio/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/directives/generated/azure/directives/sample/aio/_operations/__init__.py

@@ -15,7 +15,7 @@
 from ._operations import PollingPagingExampleOperationsMixin
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/management/generated/azure/mgmt/sample/__init__.py

@@ -19,7 +19,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/management/generated/azure/mgmt/sample/_serialization.py

@@ -1,3 +1,4 @@
+# pylint: disable=too-many-lines
 # --------------------------------------------------------------------------
 #
 # Copyright (c) Microsoft Corporation. All rights reserved.

packages/autorest.python/samples/specification/management/generated/azure/mgmt/sample/aio/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/management/generated/azure/mgmt/sample/aio/operations/__init__.py

@@ -15,7 +15,7 @@
 from ._http_success_operations import HttpSuccessOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/management/generated/azure/mgmt/sample/operations/__init__.py

@@ -15,7 +15,7 @@
 from ._http_success_operations import HttpSuccessOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v1/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v1/aio/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v1/aio/operations/__init__.py

@@ -16,7 +16,7 @@
 from ._operation_group_one_operations import OperationGroupOneOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v1/models/__init__.py

@@ -18,7 +18,7 @@
 from ._models_py3 import Product
 from ._models_py3 import TestLroAndPagingOptions
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v1/operations/__init__.py

@@ -16,7 +16,7 @@
 from ._operation_group_one_operations import OperationGroupOneOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v2/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v2/aio/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v2/aio/operations/__init__.py

@@ -17,7 +17,7 @@
 from ._operation_group_two_operations import OperationGroupTwoOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v2/models/__init__.py

@@ -16,7 +16,7 @@
 from ._models_py3 import Error
 from ._models_py3 import ModelTwo
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v2/operations/__init__.py

@@ -17,7 +17,7 @@
 from ._operation_group_two_operations import OperationGroupTwoOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v3/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v3/aio/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v3/aio/operations/__init__.py

@@ -17,7 +17,7 @@
 from ._operation_group_two_operations import OperationGroupTwoOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v3/models/__init__.py

@@ -20,7 +20,7 @@
 
 from ._multiapi_service_client_enums import ContentType
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/samples/specification/multiapi/generated/azure/multiapi/sample/v3/operations/__init__.py

@@ -17,7 +17,7 @@
 from ._operation_group_two_operations import OperationGroupTwoOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/scripts/eng/pylintrc

@@ -17,7 +17,7 @@ enable=useless-suppression
 # too-many-arguments: Due to the nature of the CLI many commands have large arguments set which reflect in large arguments set in corresponding methods.
 # too-many-lines: Due to code generation many files end up with too many lines.
 # Let's black deal with bad-continuation
-disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,consider-using-f-string,super-with-arguments,redefined-builtin,import-outside-toplevel,client-suffix-needed,unnecessary-dunder-call,unnecessary-ellipsis,disallowed-name,consider-using-max-builtin,too-many-lines,parse-error,useless-suppression,unknown-option-value
+disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,consider-using-f-string,super-with-arguments,redefined-builtin,import-outside-toplevel,client-suffix-needed,unnecessary-dunder-call,unnecessary-ellipsis,disallowed-name,consider-using-max-builtin,unknown-option-value
 
 [FORMAT]
 max-line-length=120

packages/autorest.python/test/azure/legacy/Expected/AcceptanceTests/AzureBodyDuration/bodyduration/__init__.py

@@ -19,7 +19,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/test/azure/legacy/Expected/AcceptanceTests/AzureBodyDuration/bodyduration/_serialization.py

@@ -1,3 +1,4 @@
+# pylint: disable=too-many-lines
 # --------------------------------------------------------------------------
 #
 # Copyright (c) Microsoft Corporation. All rights reserved.

packages/autorest.python/test/azure/legacy/Expected/AcceptanceTests/AzureBodyDuration/bodyduration/aio/__init__.py

@@ -16,7 +16,7 @@
 
 try:
     from ._patch import __all__ as _patch_all
-    from ._patch import *  # pylint: disable=unused-wildcard-import
+    from ._patch import *
 except ImportError:
     _patch_all = []
 from ._patch import patch_sdk as _patch_sdk

packages/autorest.python/test/azure/legacy/Expected/AcceptanceTests/AzureBodyDuration/bodyduration/aio/operations/__init__.py

@@ -15,7 +15,7 @@
 from ._duration_operations import DurationOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/test/azure/legacy/Expected/AcceptanceTests/AzureBodyDuration/bodyduration/models/__init__.py

@@ -15,7 +15,7 @@
 
 from ._models_py3 import Error
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [

packages/autorest.python/test/azure/legacy/Expected/AcceptanceTests/AzureBodyDuration/bodyduration/operations/__init__.py

@@ -15,7 +15,7 @@
 from ._duration_operations import DurationOperations
 
 from ._patch import __all__ as _patch_all
-from ._patch import *  # pylint: disable=unused-wildcard-import
+from ._patch import *
 from ._patch import patch_sdk as _patch_sdk
 
 __all__ = [