Skip to content

Added Support for EntraID identities#754

Merged
danycontre merged 52 commits intoAzure:EntraID-Storage-Featuresfrom
shawntmeyer:main
Mar 6, 2025
Merged

Added Support for EntraID identities#754
danycontre merged 52 commits intoAzure:EntraID-Storage-Featuresfrom
shawntmeyer:main

Conversation

@shawntmeyer
Copy link
Copy Markdown
Contributor

@shawntmeyer shawntmeyer commented Feb 23, 2025

Overview/Summary

This PR adds support for Entra ID identities for both FSLogix and AppAttach storage and session host configuration.

This PR fixes/adds/changes/removes

Addresses issue 746

  1. fixes - bugs with finding Azure Virtual Desktop and Azure Virtual Desktop ARM Provider service principals by changing the filter query and adding transforms and if all else fails adding Selector Blade Controls if not found.
  2. fixes - network resource group creation if no networking deployed. This was a portal bug.
  3. addition - Entra ID identity option and updates to conditions on deployments to incorporate this new feature. Existing references to EntraID changed to EntraIDKerberos to allow conditions like contains(item, 'EntraID').
  4. addition - Portal UI changes on both baseline and new Session Host brown field scenarios to support dynamic population of accelerated networking, trusted launch, and availability zone support.
  5. modify - Set-SessionHostConfiguration.ps1 script to utilize storage account keys for entra id support. Removed duplicate parameters to slim down code. Calculation of storage account name from share path. calculation of storage fqdn from sharepath.

Breaking Changes

  1. None encountered during testing but anything else that uses the Set-SessionHostConfiguration.ps1 or the bicep calling this might break. I can work through these other brown field issues if found.

Testing Evidence

Tested both EntraID and ADDS identities multiple times in my commercial and government labs. When testing make sure all files are up to date in your repo as I did change the Set-SessionHostConfig.ps1 script as well.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@danycontre danycontre changed the base branch from main to EntraID-Storage-Features March 5, 2025 20:25
@danycontre danycontre merged commit d3d80cf into Azure:EntraID-Storage-Features Mar 6, 2025
1 check passed
danycontre added a commit that referenced this pull request Mar 20, 2025
* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* Added Support for EntraID identities (#754)

* removed Key expiration

* updated Groups UI

* entraid support

* removed extra if

* testing with my branch

* remove managementvm on entraid

* update portal

* updated ui

* changed EnterpriseApp to ServicePrincipal

* updated portal

* fixed avdarm

* update RBAC

* updated url for script

* updated ui

* fixed createPrivateDNS parameter

* fixed identityDomainName in SessionHost Script

* added conditions for storage managed identity

* added logging to set session host

* changed to -command

* configure baseuri back to azure

* updated doc for identity info

* settings

* new session host brownfield fix up

* merged files

* updated json files

* fixed reference to sub

* fixed hostpool call

* updated reference

* fixed portalui for new session hosts

* fixed validation on deployment prefix

* fixed regex

* tag regex

* fixed modulo function and portal

* fixed portal screen

* update set-sessionhostconfig.ps1

* update allowed values for tags

* updated batch size

* unified changes across baseline and new session hosts

* fixed keyvault ref

* added index to UI

* updated publisher reference for all lowercase

* added count to UI

* fixed vmsize count reference

* fixed custom image in portal ui

* updated docs and reverted script path to azure repo

* fixed the servicePrincpalApiCalls

* fixed condition on serviceprincipal blade controls and outputs.

* updated to match azure repo in leue of sync

* Update deploy.bicep

---------

Co-authored-by: Dany Contreras <78437433+danycontre@users.noreply.github.com>

* updates

* updates

* fixed the filtering and added condition for info box on manageement pane.

* fixed filter on sku

* updated branch name for tests

* added filter for SKU

* added Service Principal to Role Assignment

* added ServicePrincipal to Role Assignment

* changed avdEnterpriseAppId to avdServicePrincipalId

* changed branch

* update doc

* updated share path creation in configureSessionHost.bicep

* fixed filesharepath for fslogix

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updated new session host portal ui

* added filtering for storage Account

* allowed descrption on storage account

* updates

* updates

* added new add-on for storage account key rotation

* updates

* renamed file

* fixed file name

* improved resource group drop down to show only those with cm-resource-parent tags and show value of hostPool Name to help in selection process

* have to disable roaming the recycle bin to prevent corruption of recycle bin with cloud only identities

* fixed key path

* fixed minor bug in set sessionhost script

* updates to api

* fixed loop variable

* removed bold on Resource Group

* fixed set-registryValue error

* updated name of deployments

* update batch deployment name

* updated parameter on Set-RegistryValue call for Entra ID

* updated deployment names to increment batchid + 1

* updated logging

* fixed parameter on write-log calls

* added local group membership for fslogix

* added garbage collection to hkcu unload

* added error catching

* retrieved deppref and environment from rg name

* updates

* reverting commit

* reverting commit

* reverted commit

* DesktopVirtualization AVM API Version Update for US Gov Support

* updated desktopvirtualization application avm api version

* updated more modules with gov api version

* avm update for subnets and privatednszones

* regenerate arm

* updated hostpool api version everywhere

* fixed appid to search on portal-ui

* updated graphapi filter

* fixed bug in disk encryption section of UI

* PR merge updates

* PR merge updates

* PR merge updates

* PR merge updates

* PR merge updates

* PR merge updates

* PR merge updates

* PR merge updates

* PR merge updates

* PR merge updates

---------

Co-authored-by: Dany Contreras <dany.contreras@microsoft.com>
Co-authored-by: Shawn Meyer <49066369+shawntmeyer@users.noreply.github.com>
Co-authored-by: Shawn Meyer <shmeyer@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants