Skip to content

Comments

Upgrade eslint to v10#271

Merged
mikeharder merged 4 commits intomainfrom
copilot/upgrade-eslint-to-v10
Feb 20, 2026
Merged

Upgrade eslint to v10#271
mikeharder merged 4 commits intomainfrom
copilot/upgrade-eslint-to-v10

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

Upgrade ESLint from v9 to v10 and update related packages for compatibility.

  • Dependencies (package.json):

    • eslint ^9.37.0^10.0.0
    • @eslint/js ^9.37.0^10.0.0
    • typescript-eslint ^8.46.0^8.56.0
    • Added globals ^17.3.0 — previously transitive via @eslint/eslintrc, which v10 removes
  • Engine requirement (package.json): Bumped engines.node from >=20.0.0 to >=20.19.0 to align with ESLint v10's minimum Node.js version (^20.19.0 || ^22.13.0 || >=24).

  • Lint fix (src/readme.ts): Fixed no-useless-assignment error (new in eslint:recommended v10) by collapsing a redundant let + if/else into a ternary:

// before
let filteredTags = normalTags
if (versionType === 'preview') {
  filteredTags = normalTags.filter((t) => t.includes('preview'))
} else {
  filteredTags = normalTags.filter((t) => !t.includes('preview'))
}

// after
const filteredTags =
  versionType === 'preview'
    ? normalTags.filter((t) => t.includes('preview'))
    : normalTags.filter((t) => !t.includes('preview'))

No changes to eslint.config.js — the existing flat config is already v10-compatible.

Original prompt

This section details on the original issue you should resolve

<issue_title>upgrade eslint to v10</issue_title>
<issue_description>- [ ] upgrade eslint to v10

  • upgrade related packages to latest versions to ensure compat
  • fix or suppress any code errors
    </issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot AI changed the title [WIP] Upgrade eslint to v10 and related packages Upgrade eslint to v10 Feb 20, 2026
Copilot AI requested a review from mikeharder February 20, 2026 08:39
@mikeharder mikeharder marked this pull request as ready for review February 20, 2026 08:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the repository’s linting toolchain to ESLint v10 and updates related dependencies/lockfile entries to keep the existing flat ESLint config working, plus a small TypeScript refactor to satisfy a newly-enabled recommended rule.

Changes:

  • Bumped eslint / @eslint/js to v10 and updated typescript-eslint; added globals as a direct devDependency.
  • Updated package-lock.json to reflect the new dependency graph after the ESLint v10 upgrade.
  • Refactored getLatestTag in src/readme.ts to avoid no-useless-assignment under ESLint v10.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/readme.ts Refactors tag filtering logic to satisfy ESLint v10 recommended rules.
package.json Updates devDependencies for ESLint v10 + related tooling; adds globals.
package-lock.json Lockfile refresh for the upgraded lint/tooling dependency tree.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot AI requested a review from mikeharder February 20, 2026 18:54
@mikeharder mikeharder enabled auto-merge (squash) February 20, 2026 19:06
@mikeharder mikeharder merged commit 30565ac into main Feb 20, 2026
11 checks passed
@mikeharder mikeharder deleted the copilot/upgrade-eslint-to-v10 branch February 20, 2026 19:18
@mikeharder mikeharder moved this to 🔬 Dev in PR in Azure SDK EngSys 📆🎇 Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔬 Dev in PR

Development

Successfully merging this pull request may close these issues.

upgrade eslint to v10

3 participants