Update setup command to use platform appropriate requirements.txt file.#102
Merged
tjprescott merged 3 commits intoAzure:masterfrom Jul 1, 2019
Merged
Conversation
tjprescott
reviewed
Jul 1, 2019
Member
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
Overall LGTM. Just one question on when there isn't an available requirements file.
| "Installing external dependencies...", | ||
| ) | ||
| else: | ||
| warnings.warn('platform {} does not have pinned dependencies, using latest compatible from PyPI.') |
Member
There was a problem hiding this comment.
Should this be a warning or an error?
Member
Author
There was a problem hiding this comment.
IMHO, just a warning will do. The only people that will ever hit this code path are people not using Windows, MacOS, or Linux (i.e. FreeBSD, OS/2, etc users.) If it's an error they won't be able to get setup at all. If it stays as a warning, they'll just be given a heads up that they'll be using a set of dependencies we haven't tested.
tjprescott
approved these changes
Jul 1, 2019
tjprescott
added a commit
that referenced
this pull request
Jul 2, 2019
Merged
RenSilvaAU
pushed a commit
to RenSilvaAU/azure-cli-dev-tools
that referenced
this pull request
Aug 7, 2025
Remove python-Levenshtein
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that folks doing development have the same version of the dependencies on their local machines that we will eventually distribute the CLI with.