Skip to content

[Linter] Show command should use g.show_command or g.custom_show_command#241

Merged
mmyyrroonn merged 15 commits intoAzure:masterfrom
mmyyrroonn:fix-233-show-command
Aug 25, 2020
Merged

[Linter] Show command should use g.show_command or g.custom_show_command#241
mmyyrroonn merged 15 commits intoAzure:masterfrom
mmyyrroonn:fix-233-show-command

Conversation

@mmyyrroonn
Copy link
Copy Markdown
Contributor

In order to have consistent error message and syseixt code, show command should use g.show_command or g.custom_show_command instead of g.command or g.custom_command.

Comment thread azdev/operations/linter/__init__.py Outdated
Copy link
Copy Markdown
Contributor

@haroldrandom haroldrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basicallu, good to me. Thanks, learnt a lot.

Copy link
Copy Markdown
Contributor

@haroldrandom haroldrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basicallu, good to me. Thanks, learnt a lot. Pls fix the test first

@haroldrandom haroldrandom added the Linter azdev linter label Aug 10, 2020
@mmyyrroonn
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mmyyrroonn
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mmyyrroonn mmyyrroonn force-pushed the fix-233-show-command branch from 9f8e266 to 2a5ab21 Compare August 25, 2020 02:56
@mmyyrroonn mmyyrroonn merged commit cdd0ed3 into Azure:master Aug 25, 2020
@mmyyrroonn mmyyrroonn deleted the fix-233-show-command branch August 25, 2020 05:50
RenSilvaAU pushed a commit to RenSilvaAU/azure-cli-dev-tools that referenced this pull request Aug 7, 2025
* release 1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Linter azdev linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants