Skip to content

fix object dump failure #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AllyW merged 2 commits into from
May 10, 2023
Merged

fix object dump failure #370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7af0129
fix object dump failure
AllyW May 10, 2023
3fd3bb4
reserve basic type for json dump
AllyW May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions azdev/operations/command_change/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@ def gen_command_meta(command_info, with_help=False, with_example=False):
if settings.get("nargs", None):
para["nargs"] = settings["nargs"]
if settings.get("default", None):
para["default"] = settings["default"]
if not isinstance(settings["default"], (float, int, str, list, bool)):
para["default"] = str(settings["default"])
Comment thread
AllyW marked this conversation as resolved.
else:
para["default"] = settings["default"]
if with_help:
para["desc"] = settings["help"]
if command_info["is_aaz"] and command_info["az_arguments_schema"]:
Expand Down Expand Up @@ -172,7 +175,7 @@ def gen_commands_meta(commands_meta, meta_output_path=None):
for key, module_info in commands_meta.items():
file_name = "az_" + key + "_meta.json"
if meta_output_path:
file_name = meta_output_path + file_name
file_name = meta_output_path + "/" + file_name
file_folder = os.path.dirname(file_name)
if file_folder and not os.path.exists(file_folder):
os.makedirs(file_folder)
Expand Down