add version upgrade#426
Conversation
|
Hi @AllyW, |
|
|
||
| class VersionUpgradeMod: | ||
|
|
||
| def __init__(self, module_name, current_version, is_preview, is_experimental, |
There was a problem hiding this comment.
Is there any reason to keep is_experimental?
There was a problem hiding this comment.
This is passed from current raw metadata and used to check whether to insert isPreview tag to next extension version for old cli users.
| return "".join([str(item) for item in version_arr]) | ||
|
|
||
|
|
||
| class VersionUpgradeMod: |
There was a problem hiding this comment.
I think version upgrade code should be in azdev instead of azure-cli-diff-tool.
There was a problem hiding this comment.
Version upgrade is working based on diff tool, and in extension ci, version calculation is planned to be used as func call, so packaged with meta-diff together. azdev can expose related cmd later if needed.
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
Handle 204 response
2 participants
No description provided.