add deprecate diff support#438
Merged
Merged
Conversation
|
Hi @AllyW, |
AllyW
force-pushed
the
deprecate-info-diff
branch
from
1d2e60c to
89ead63
Compare
Member
|
/azp run |
AllyW
force-pushed
the
deprecate-info-diff
branch
from
8bf2e20 to
0eb1baf
Compare
| "1012": "please confirm sub group `{0}` removed", | ||
| "1013": "please remove property `{0}` for sub group `{1}`", | ||
| "1014": "please add back property `{0}` for sub group `{1}`", | ||
| "1015": "please change property `{0}` from `{1}` to `{2}` for sub group `{3}`", |
Member
There was a problem hiding this comment.
I think name variables will make the code more readable, but this may increase the effort.
|
|
||
|
|
||
| def extract_subgroup_property(key, subgroup_name): | ||
| subgroup_key_pattern = re.compile(subgroup_name + r"\'\]\[\'([a-zA-Z0-9\-\_]+)\'\]") |
Member
There was a problem hiding this comment.
Can you add an example for regex?
Contributor
Author
There was a problem hiding this comment.
added a test for this fun
wangzelin007
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.