Skip to content

Conversation

@calvinhzy
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Remove deprecated command groups az storage blob access, az storage blob directory, az storage blob move since the az storage fs command group has been GA since 2021
az storage account local-user only mark some params in create/update as preview as the rest have been GA in main rep
remove is_preview tags for params that have been GA already

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

…e blob directory`, `az storage blob move` since the `az storage fs` command group has been GA since 2021
…te` as preview as the rest have been GA in main repo
@calvinhzy calvinhzy self-assigned this Jan 14, 2025
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 14, 2025

❌Azure CLI Extensions Breaking Change Test
❌storage-preview
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove storage blob sub group storage blob removed please confirm sub group storage blob removed
⚠️ 1004 - CmdPropRemove storage account local-user create cmd storage account local-user create removed property is_preview
⚠️ 1004 - CmdPropRemove storage account local-user delete cmd storage account local-user delete removed property is_preview
⚠️ 1004 - CmdPropRemove storage account local-user list cmd storage account local-user list removed property is_preview
⚠️ 1004 - CmdPropRemove storage account local-user list-keys cmd storage account local-user list-keys removed property is_preview
⚠️ 1004 - CmdPropRemove storage account local-user regenerate-password cmd storage account local-user regenerate-password removed property is_preview
⚠️ 1004 - CmdPropRemove storage account local-user show cmd storage account local-user show removed property is_preview
⚠️ 1004 - CmdPropRemove storage account local-user update cmd storage account local-user update removed property is_preview

@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jan 14, 2025

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 14, 2025

Storage-Preview

@calvinhzy calvinhzy marked this pull request as draft January 14, 2025 08:07
@calvinhzy calvinhzy marked this pull request as ready for review January 15, 2025 03:39
@calvinhzy calvinhzy changed the title {Storage-Preview} Remove deprecated command groups, remove preview tags for commands that have been GA in main repo {Storage-Preview} az storage blob access/directory/move: Remove deprecated command groups, remove preview tags for commands that have been GA in main repo Jan 15, 2025
@calvinhzy calvinhzy merged commit f5008af into Azure:main Jan 15, 2025
22 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ storage-preview-1.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=112535437&view=results

Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
…recated command groups, remove preview tags for commands that have been GA in main repo (Azure#8416)

* remove deprecated command groups `az storage blob access`, `az storage blob directory`, `az storage blob move` since the `az storage fs` command group has been GA since 2021

* `az storage account local-user` only mark some params in `create/update` as preview as the rest have been GA in main repo

* remove is_preview tags for params that have been GA already

* update version

* remove deprecated tests, also remove vendered sdk, client factory and help, lint

* remove CUSTOM_DATA_STORAGE_ADLS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants