-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS} Fix several tests #8975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} Fix several tests #8975
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @FumingZhang, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes several tests in the AKS extension that were failing due to dependency bumps. The primary change is updating Azure KeyVault API version references in test recordings to ensure compatibility with newer dependencies.
- Updates Azure KeyVault API version from 2023-02-01 to 2024-11-01 in test recordings
- Maintains existing test functionality while ensuring compatibility with updated dependencies
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Hi @FumingZhang Release SuggestionsModule: aks-preview
Notes
|
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
test_aks_approuting_updateandtest_aks_approuting_update_with_monitoring_addon_enabledare marked as live only, the corresponding recording files are useless so removing them.az aks namespaceto use client (SDK) initiated from cli-extensions/aks-previewGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.