-
Notifications
You must be signed in to change notification settings - Fork 1.5k
az connectedk8s -Release v1.10.8 #8989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
az connectedk8s -Release v1.10.8 #8989
Conversation
* forcedelete * format * add code owner * mypy
* Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com>
Co-authored-by: mmcneal <mmcneal@microsoft.com>
* update errors * format * style
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR releases version 1.10.8 of the connectedk8s Azure CLI extension, focused on improving cloud portability and error handling. The main purpose is to parameterize Microsoft Container Registry (MCR) URLs for air-gapped clouds and enhance error messaging for better troubleshooting.
Key changes include:
- Parameterized MCR URLs to support different Azure cloud environments (USSec, USNat, etc.)
- Enhanced error messages with standardized warning strings for better user guidance
- Fixed a critical spelling error in the CLICommand import affecting multiple function signatures
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump from 1.10.7 to 1.10.8 |
| custom.py | Core changes including MCR URL parameterization, error message standardization, and CLICommand spelling fixes |
| _binaryutils.py | Updated proxy download logic to use parameterized MCR URLs |
| _utils.py | Added get_mcr_path utility function and enhanced error messaging |
| _precheckutils.py | Updated diagnostic checks to use parameterized MCR URLs |
| _constants.py | Updated registry paths and added standardized error message constants |
| _proxylogic.py | Fixed CLICommand spelling error |
| test_connectedk8s_scenario.py | Updated test to use parameterized MCR URLs |
| HISTORY.rst | Added release notes for version 1.10.8 |
| CODEOWNERS | Added new maintainer to the connectedk8s team |
| # default for public, mc, ff clouds | ||
| cloud_based_domain = active_directory_array[2] | ||
| # special cases for USSec/USNat clouds | ||
| if len(active_directory_array) == 4: |
Copilot
AI
Jul 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cloud domain parsing logic is duplicated between get_default_config_dp_endpoint and crd_cleanup_force_delete. Consider extracting this into the existing get_mcr_path utility function or a new shared utility function to reduce code duplication.
|
|
We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here: As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite |
|
@zhoxing-ms can you please help with this PR? |
|
[Release] Update index.json for extension [ connectedk8s-1.10.8 ] : https://dev.azure.com/msazure/One/_build/results?buildId=131315170&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az connectedk8s
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.