Skip to content

Conversation

@atchutbarli
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedk8s

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Bavneet Singh and others added 11 commits March 18, 2025 15:11
* forcedelete

* format

* add code owner

* mypy
* Add parameterization for the airgapped clouds

* Fix azdev style

* MCR path function

* azdev, ruff, and mypy

---------

Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com>
Co-authored-by: mmcneal <mmcneal@microsoft.com>
Copilot AI review requested due to automatic review settings July 22, 2025 00:34
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 22, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 22, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR releases version 1.10.8 of the connectedk8s Azure CLI extension, focused on improving cloud portability and error handling. The main purpose is to parameterize Microsoft Container Registry (MCR) URLs for air-gapped clouds and enhance error messaging for better troubleshooting.

Key changes include:

  • Parameterized MCR URLs to support different Azure cloud environments (USSec, USNat, etc.)
  • Enhanced error messages with standardized warning strings for better user guidance
  • Fixed a critical spelling error in the CLICommand import affecting multiple function signatures

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
setup.py Version bump from 1.10.7 to 1.10.8
custom.py Core changes including MCR URL parameterization, error message standardization, and CLICommand spelling fixes
_binaryutils.py Updated proxy download logic to use parameterized MCR URLs
_utils.py Added get_mcr_path utility function and enhanced error messaging
_precheckutils.py Updated diagnostic checks to use parameterized MCR URLs
_constants.py Updated registry paths and added standardized error message constants
_proxylogic.py Fixed CLICommand spelling error
test_connectedk8s_scenario.py Updated test to use parameterized MCR URLs
HISTORY.rst Added release notes for version 1.10.8
CODEOWNERS Added new maintainer to the connectedk8s team

# default for public, mc, ff clouds
cloud_based_domain = active_directory_array[2]
# special cases for USSec/USNat clouds
if len(active_directory_array) == 4:
Copy link

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cloud domain parsing logic is duplicated between get_default_config_dp_endpoint and crd_cleanup_force_delete. Consider extracting this into the existing get_mcr_path utility function or a new shared utility function to reduce code duplication.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

@atchutbarli
Copy link
Contributor Author

We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here:
https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/testing/test/configurations

As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

@atchutbarli
Copy link
Contributor Author

atchutbarli commented Jul 23, 2025

@zhoxing-ms can you please help with this PR?

@zhoxing-ms zhoxing-ms merged commit 09e51e3 into Azure:main Jul 23, 2025
22 of 24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedk8s-1.10.8 ] : https://dev.azure.com/msazure/One/_build/results?buildId=131315170&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants