Skip to content

Conversation

@ShichaoQiu
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ShichaoQiu ShichaoQiu requested a review from howang-ms as a code owner October 31, 2025 05:23
Copilot AI review requested due to automatic review settings October 31, 2025 05:23
@ShichaoQiu ShichaoQiu requested a review from Juliehzl as a code owner October 31, 2025 05:23
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 31, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate containerapp sessionpool create cmd containerapp sessionpool create update parameter container_type: updated property choices from ['CustomContainer', 'NodeLTS', 'PythonLTS'] to ['CustomContainer', 'NodeLTS', 'PythonLTS', 'Shell']

@azure-client-tools-bot-prd
Copy link

Hi @ShichaoQiu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 31, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @ShichaoQiu

Release Suggestions

Module: containerapp

  • Update VERSION to 1.2.0b5 in src/containerapp/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new "Shell" container type to the containerapp sessionpool create command. This enhancement extends the existing functionality that previously supported only CustomContainer, PythonLTS, and NodeLTS container types.

  • Added "Shell" as a new container type option for session pools
  • Updated test coverage to include Shell container type validation
  • Added help documentation with usage example

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

File Description
src/containerapp/azext_containerapp/_params.py Added "Shell" to the enum of available container types for sessionpool create
src/containerapp/azext_containerapp/_help.py Added example showing how to create a Shell container type session pool
src/containerapp/azext_containerapp/tests/latest/test_containerapp_sessionpool.py Renamed test method to indicate e2e testing, added test for Shell container type creation, updated expected pool count assertions, and added cleanup for Shell pool
src/containerapp/HISTORY.rst Added release note documenting the new Shell container type feature

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 31, 2025

Please fix CI issues

@zhoxing-ms zhoxing-ms merged commit c802f16 into Azure:main Nov 5, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants