[AKS] az aks update: Set CMK property "enabled" to false and remove other CMK properties when enable PMK on a CMK-disabled cluster
#9385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingosummer
requested review from
FumingZhang and
andyliuliming
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
|
github-actions
bot
added
the
release-version-block
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables PMK (Platform-Managed Keys) to be activated on AKS clusters that previously had CMK (Customer-Managed Keys) disabled, ensuring proper cleanup of stale CMK properties.
- Version bump from 19.0.0b10 to 19.0.0b11
- Modified
update_kms_pmk_cmk()to clear CMK properties when enabling PMK on CMK-disabled clusters - Added comprehensive test coverage for the new scenario
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump to 19.0.0b11 |
| managed_cluster_decorator.py | Added logic to detect and clear stale CMK properties when enabling PMK on CMK-disabled clusters |
| test_managed_cluster_decorator.py | Added unit test verifying CMK property cleanup when enabling PMK on CMK-disabled cluster |
| test_aks_commands.py | Added end-to-end integration test for the CMK → disable CMK → enable PMK workflow |
| HISTORY.rst | Updated changelog with new version and feature description |
AbelHu
reviewed
Nov 4, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
… other CMK properties when enable PMK on a CMK-disabled cluster
bingosummer
force-pushed
the
binxi/aks-k2p-disable-cmk
branch
from
50ef379 to
3615ca1
Compare
github-actions
bot
removed
the
release-version-block
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
reviewed
Nov 5, 2025
| name_prefix="clitest", | ||
| location="eastus2euap", | ||
| ) | ||
| def test_aks_create_with_kms_cmk_and_disable_cmk_and_update_pmk( |
FumingZhang
approved these changes
Nov 5, 2025
yanzhudd
approved these changes
Nov 6, 2025
Collaborator
|
[Release] Update index.json for extension [ aks-preview-19.0.0b11 ] : https://dev.azure.com/msazure/One/_build/results?buildId=142827702&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.