{Firewall} Remove __import__('pkg_resources').declare_namespace(__name__)#9586
{Firewall} Remove __import__('pkg_resources').declare_namespace(__name__)#9586yanzhudd merged 4 commits intoAzure:mainfrom
__import__('pkg_resources').declare_namespace(__name__)#9586Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
Bumps the azure-firewall extension patch version and removes a legacy pkg_resources namespace-package declaration from the vendored SDKs package, aligning with modern setuptools behavior and avoiding pkg_resources runtime coupling.
Changes:
- Bump extension version from
2.0.0to2.0.1. - Remove
__import__('pkg_resources').declare_namespace(__name__)fromazext_firewall.vendored_sdks. - Add a 2.0.1 entry to
HISTORY.rstdescribing the change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/azure-firewall/setup.py |
Patch version bump to 2.0.1. |
src/azure-firewall/azext_firewall/vendored_sdks/__init__.py |
Removes pkg_resources namespace declaration. |
src/azure-firewall/HISTORY.rst |
Adds release note for 2.0.1. |
| 2.0.1 | ||
| ++++++ | ||
| * Remove `__import__('pkg_resources').declare_namespace(__name__)` to fix the namespace package issue. |
There was a problem hiding this comment.
In HISTORY.rst, release notes entries appear to consistently be bullet points (e.g., 2.0.0 and most subsequent releases). The 2.0.1 note is currently a plain paragraph; please format it as a bullet (prefix with *) for consistency with the rest of the changelog.
…zure-cli-extensions into pkg-resources-firewall
|
[Release] Update index.json for extension [ azure-firewall-2.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=152559307&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
pypa/setuptools@03f3615#diff-61d113525e9cc93565799a4bb8b34a68e2945b8a3f7d90c81380614a4ea39542R2-R7
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.