Skip to content

{Firewall} Remove __import__('pkg_resources').declare_namespace(__name__)#9586

Merged
yanzhudd merged 4 commits intoAzure:mainfrom
necusjz:pkg-resources-firewall
Feb 10, 2026
Merged

{Firewall} Remove __import__('pkg_resources').declare_namespace(__name__)#9586
yanzhudd merged 4 commits intoAzure:mainfrom
necusjz:pkg-resources-firewall

Conversation

@necusjz
Copy link
Copy Markdown
Member

@necusjz necusjz commented Feb 10, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

pypa/setuptools@03f3615#diff-61d113525e9cc93565799a4bb8b34a68e2945b8a3f7d90c81380614a4ea39542R2-R7

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@necusjz necusjz self-assigned this Feb 10, 2026
@necusjz necusjz requested a review from kairu-ms as a code owner February 10, 2026 02:46
Copilot AI review requested due to automatic review settings February 10, 2026 02:46
@necusjz necusjz requested a review from jsntcy as a code owner February 10, 2026 02:46
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 10, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 10, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the azure-firewall extension patch version and removes a legacy pkg_resources namespace-package declaration from the vendored SDKs package, aligning with modern setuptools behavior and avoiding pkg_resources runtime coupling.

Changes:

  • Bump extension version from 2.0.0 to 2.0.1.
  • Remove __import__('pkg_resources').declare_namespace(__name__) from azext_firewall.vendored_sdks.
  • Add a 2.0.1 entry to HISTORY.rst describing the change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/azure-firewall/setup.py Patch version bump to 2.0.1.
src/azure-firewall/azext_firewall/vendored_sdks/__init__.py Removes pkg_resources namespace declaration.
src/azure-firewall/HISTORY.rst Adds release note for 2.0.1.

Comment on lines +6 to +8
2.0.1
++++++
* Remove `__import__('pkg_resources').declare_namespace(__name__)` to fix the namespace package issue.
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In HISTORY.rst, release notes entries appear to consistently be bullet points (e.g., 2.0.0 and most subsequent releases). The 2.0.1 note is currently a plain paragraph; please format it as a bullet (prefix with *) for consistency with the rest of the changelog.

Copilot uses AI. Check for mistakes.
@yanzhudd yanzhudd merged commit f34eaed into Azure:main Feb 10, 2026
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ azure-firewall-2.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=152559307&view=results

jepetty pushed a commit to jepetty/azure-cli-extensions that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants