Skip to content

[front-door] Add WAF rule create examples#9860

Merged
necusjz merged 1 commit into
Azure:mainfrom
Ptnan7:fix/front-door-waf-rule-create-help
May 14, 2026
Merged

[front-door] Add WAF rule create examples#9860
necusjz merged 1 commit into
Azure:mainfrom
Ptnan7:fix/front-door-waf-rule-create-help

Conversation

@Ptnan7
Copy link
Copy Markdown
Member

@Ptnan7 Ptnan7 commented May 13, 2026

Summary

  • Replace obsolete --defer guidance for az network front-door waf-policy rule create
  • Add create examples that include the initial match condition via --match-variable, --operator, and --values
  • Include examples for both MatchRule and RateLimitRule

Related issue

Validation

  • python -m py_compile src\front-door\azext_front_door\_help.py

Fixes Azure/azure-cli#32736

Update the WAF custom rule create help to document the inline match condition arguments and replace the obsolete --defer guidance with direct create examples.

Fixes Azure/azure-cli#32736

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 13, 2026 02:29
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 13, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @Ptnan7,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 13, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Front Door extension command help for az network front-door waf-policy rule create to remove obsolete --defer guidance and provide clearer creation guidance for custom WAF rules.

Changes:

  • Removes outdated --defer wording from the waf-policy rule create help text.
  • Adds a long summary explaining the need for at least one match condition and how to provide it during creation.
  • Adds two new create examples covering both MatchRule and RateLimitRule with an initial match condition.

Comment on lines +395 to +397
A custom rule must contain at least one match condition. Provide the initial match condition with
--match-variable, --operator, and --values when creating the rule, or add match conditions later with
az network front-door waf-policy rule match-condition add.
@github-actions
Copy link
Copy Markdown
Contributor

Hi @Ptnan7

Release Suggestions

Module: front-door

  • Please log updates into to src/front-door/HISTORY.rst
  • Update VERSION to 2.2.1 in src/front-door/setup.py

Notes

@necusjz
Copy link
Copy Markdown
Member

necusjz commented May 13, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit d82c241 into Azure:main May 14, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Reference feedback]: --defer option is replaced with --add option. but no example sample to show how to use --add option

4 participants