[ACR] Add OCI Artifact Source Context#14576
Conversation
| commit_trigger_enabled = False | ||
| pull_request_trigger_enabled = False | ||
|
|
||
| if context_path.lower().startswith("oci://"): |
There was a problem hiding this comment.
@akashsinghal this will throw a null exception if the above case is met and we set context_path = None. Please add a null check here before calling .lower()
|
LGTM. Could you pls add some test? |
|
@akashsinghal can you fix the CI failure? |
|
@yungezz @fengzhou-msft Please do not merge this PR. These additions are reliant on new internal changes in ACR to be deployed to production and will be ready to merge after that has occurred. As for added tests, we will add a new test for this feature after global ACR deployment. Thanks! /cc: @northtyphoon @shahzzzam |
|
This Looks good to me now. It's ok to merge this. Internal changes to ACR have now been deployed. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
hi @fengzhou-msft could you pls review and merge this PR? it's ready to merge now |
6 participants
Description
Currently, ACR CLI does not support an OCI artifact to be passed in as the source context or source location for any of the commands. We are adding support for this new third type of remote context and need to add CLI support for contexts provided of form
oci://myregistry.azurecr.io/artifact.Testing Guide
az acr build -f Dockerfile -r myregistry oci://myregistry.azurecr.io/artifact:v1This command will take the provided source context (oci://) and use the Dockerfile downloaded from this source context to build. (Need to change registry with own registry. Need to change artifact link with own artifact uploaded to registry)az acr run -f acb.yaml -r myregistry oci://myregistry.azurecr.io/artifact:v2This command will take the provided source context (oci://) and use the acb.yaml downloaded from this source context to run the task. (Need to change registry with own registry. Need to change artifact link with own artifact uploaded to registry)This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.