[Network] VPN Gateway fixes#1474
[Network] VPN Gateway fixes#1474tjprescott merged 3 commits intoAzure:masterfrom tjprescott:VpnGatewayFixes
Conversation
|
@tjprescott, thanks for your PR! By analyzing the history of the files in this pull request, we identified @derekbekoe to be a potential reviewer. |
|
cc/ @aanandr |
yugangw-msft
left a comment
yugangw-msft
left a comment
There was a problem hiding this comment.
Suggest 2 minor change. Feel free to merge thereafter.
| gateway1_id = '/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/virtualNetworkGateways/{}'.format(subscription_id, rg, self.gateway1_name) | ||
| gateway2_id = '/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/virtualNetworkGateways/{}'.format(subscription_id, rg, self.gateway2_name) | ||
|
|
||
| self.cmd('network vpn-connection create -n myconnection -g {} --shared-key 123 --vnet-gateway1-id {} --vnet-gateway2-id {}'.format(rg, gateway1_id, gateway2_id)) |
There was a problem hiding this comment.
should we add any verification here?
There was a problem hiding this comment.
In this case, the command returns nothing, so there's nothing to verify as long as it doesn't fail. I might add more of the VPN-connection commands to this test when I go through that one, but that will involve re-recording so I will hold off for now.
| register_cli_argument('network vpn-gateway', 'gateway_name', help='Virtual network gateway name') | ||
| register_cli_argument('network vpn-gateway', 'gateway_type', help='The gateway type.', **enum_choice_list(gatewayType)) | ||
| register_cli_argument('network vpn-gateway', 'sku', help='VPN gateway SKU.', **enum_choice_list(sku)) | ||
| register_cli_argument('network vpn-gateway', 'vpn_type', help='VPN gateway type.', **enum_choice_list(vpnType)) |
There was a problem hiding this comment.
I suggest rename to vpn_gateway_type. vpn_type could mean site to site or point to site
There was a problem hiding this comment.
I renamed it for the custom command, but left the fat client template alone for fear that it would require me to re-record the 1-2 hour long test.
There was a problem hiding this comment.
@tjprescott, understood. Let us get to it later. I have merged my PR for no-wait, and it will get re-recording faster
|
|
haroldrandom
added
Breaking Change
cla-not-required
Network
5 participants
Fixes #1458 and partially addresses #818.
vpn-gateway updatecommand.--subnet-idand replaces it with--vnetwhich accepts the name or ID of a VNet. The subnet name is fixed (service requires it to be 'GatewaySubnet'). breaking change