-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{App Config} Fix #12668860, #12668922: Fix validations while importing kvset #20491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{App Config} Fix #12668860, #12668922: Fix validations while importing kvset #20491
Conversation
|
@avanigupta, @shenmuxiaosen please take a look! |
|
App Config |
|
@pratiksanglikar |
src/azure-cli/azure/cli/command_modules/appconfig/_kv_helpers.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/appconfig/_kv_helpers.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/appconfig/_kv_helpers.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/appconfig/_kv_helpers.py
Outdated
Show resolved
Hide resolved
|
@pratiksanglikar Could you please address those comments from @shenmuxiaosen, and ask him to review this PR again and approve it Please note that if you can't address these comments today, this PR will not catch up with the release date of this sprint and can only be postponed to the next sprint (2022-01-04) |
shenmuxiaosen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
@zhoxing-ms, The PR has been signed off. |
DONE |
Description
az appconfig importwhenappconfig/kvsetprofile is used and tags are not in string format.az appconfig importcommand andappconfig/kvsetprofile was used for import.The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.