Skip to content

Conversation

@pratiksanglikar
Copy link
Contributor

@pratiksanglikar pratiksanglikar commented Nov 24, 2021

Description

  • Fixes #12668922 Added validations to the command az appconfig import when appconfig/kvset profile is used and tags are not in string format.
  • Fixes #12668860 Handled cases where optional parameters were present in the import file for az appconfig import command and appconfig/kvset profile was used for import.

@pratiksanglikar
Copy link
Contributor Author

@avanigupta, @shenmuxiaosen please take a look!

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 24, 2021

App Config

@wangzelin007
Copy link
Member

@pratiksanglikar
Please fix the CLI Style error, you can run azdev style appconfig to check the error in your local environment.
And add @avanigupta Avani Gupta FTE, @shenmuxiaosen Shuai Wang FTE to Reviewers.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Dec 2, 2021

@pratiksanglikar Could you please address those comments from @shenmuxiaosen, and ask him to review this PR again and approve it

Please note that if you can't address these comments today, this PR will not catch up with the release date of this sprint and can only be postponed to the next sprint (2022-01-04)

Copy link
Contributor

@shenmuxiaosen shenmuxiaosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pratiksanglikar
Copy link
Contributor Author

@zhoxing-ms, The PR has been signed off.
Can you please include this PR in today's release?
cc: @wangzelin007

@wangzelin007
Copy link
Member

@zhoxing-ms Xing Zhou FTE, The PR has been signed off. Can you please include this PR in today's release? cc: @wangzelin007 Zelin Wang FTE

DONE

@wangzelin007 wangzelin007 merged commit ba6065c into Azure:dev Dec 2, 2021
@pratiksanglikar pratiksanglikar deleted the prsangli/fixKvsetImportValidations branch December 3, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants