[AKS] GA Kubernetes version alias#22456
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom May 16, 2022
Merged
Conversation
…w table output contain currentKubernetesVersion column
zjpjack
requested review from
andyliuliming,
jsntcy and
zhoxing-ms
as code owners
ghost
requested a review
from 
ghost
assigned
zjpjack
changed the title
Collaborator
|
AKS |
moreOver0
reviewed
May 16, 2022
| """Validates a string as a possible Kubernetes version. An empty string is also valid, which tells the server | ||
| to use its default version.""" | ||
| if namespace.kubernetes_version: | ||
| k8s_release_regex = re.compile(r'^[v|V]?(\d+\.\d+\.\d+.*)$') |
Contributor
There was a problem hiding this comment.
Is reducing the .* expected?
Contributor
Author
There was a problem hiding this comment.
yes, this is expected. Actually, the original regex has some issues. With .*, some version like 1.2.3.4 is allowed, but we only allow major.minor.patch, which is 1.2.3 is allowed. And our new regex will allow both 1.2 or 1.2.3, but 1.2.3.4 is not allowed.
moreOver0
approved these changes
May 16, 2022
zhoxing-ms
approved these changes
May 16, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zhoxing-ms
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create --kubernetes-version
az aks show
Description
(1) AKS supports ManagedCluster kubernetes version with format major.minor, so remove the original limitation version number must have patch number
(2) AKS has both kubernetesVersion and currentKubernetesVersion, currentKubernetesVersion is the actual version that MC running. We add it in the az aks show command
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.