[AKS] az aks: Add --gpu-instance-profile for Nvidia multi-instan…#23501
Merged
zhoxing-ms merged 4 commits intoAzure:devfrom Aug 18, 2022
Merged
[AKS] az aks: Add --gpu-instance-profile for Nvidia multi-instan…#23501zhoxing-ms merged 4 commits intoAzure:devfrom
az aks: Add --gpu-instance-profile for Nvidia multi-instan…#23501zhoxing-ms merged 4 commits intoAzure:devfrom
Conversation
alexeldeib
requested review from
andyliuliming,
jsntcy and
zhoxing-ms
as code owners
ghost
requested a review
from 
ghost
assigned
alexeldeib
changed the title
az aks: Add --gpu-instance-profile for Nvidia multi-instan…az aks: Add --gpu-instance-profile for Nvidia multi-instan…
alexeldeib
force-pushed
the
ace/mig
branch
3 times, most recently
from
d8077f7 to
84dbdd3
Compare
Collaborator
|
AKS |
FumingZhang
reviewed
Aug 11, 2022
| ) | ||
| self.assertEqual(ctx_1.get_no_wait(), False) | ||
|
|
||
| def common_set_up_gpu_propertes(self): |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
think I got them all?
Member
There was a problem hiding this comment.
Yes, but this function seems to be called nowhere, maybe remove it?
Queued a pipeline to validate the live test case.
Member
There was a problem hiding this comment.
Oops, sorry for the late reply. Looks all good to me 
zhoxing-ms
approved these changes
Aug 18, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ce gpu
Related command
az aks create --gpu-instance-profile
az aks nodepool add --gpu-instance-profile
Description
Support multi instance gpus for AKS.
Testing Guide
see live test
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.