{Upgrade} Fix KeyError: 'pypi' when auto upgrade #26106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
May 2023 (2023-05-23) - For Build (Breaking change release) milestone
|
Hi @bebound, |
ghost
added
ghost
requested a review
from 
Collaborator
|
Core |
Member
Can't agree more. |
jiasli
reviewed
Apr 12, 2023
| get_cached_latest_versions() | ||
| from packaging.version import parse | ||
| if parse(VERSIONS['versions']['core']['local']) < parse(VERSIONS['versions']['core']['pypi']): # pylint: disable=line-too-long | ||
| if 'pypi' in VERSIONS['versions']['core'] and parse(VERSIONS['versions']['core']['local']) < parse(VERSIONS['versions']['core']['pypi']): # pylint: disable=line-too-long |
Member
There was a problem hiding this comment.
I think we should fix the invalid ~/.azure/versionCheck.json, instead of here, since it is the file that introduces inconsistency and complexity.
Contributor
Author
There was a problem hiding this comment.
This file is refreshed after 11 days, so I'd like to leave it there.
Skipping it or setting a dummy value for pypi produces the same result. I don't want to make the logic more complicate.
bebound
modified the milestones:
May 2023 (2023-05-23) - For Build (Breaking change release),
Backlog
bebound
changed the title
jiasli
approved these changes
Apr 21, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
Approving in 2025. Looking at my comments, they seem to be from my past life. |
️✔️AzureCLI-BreakingChangeTest
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #20473
The full error is
So it's easy to fix. But the cause is pretty tricky.
CLI gets latest version from GitHub.
azure-cli/src/azure-cli-core/azure/cli/core/util.py
Lines 316 to 330 in 5757778
pypiis added in line 327. Ifcheck_connectivityorget_latest_from_githubfails, this key does not exist.A wrong
~/.azure/versionCheck.jsonis also generated with this content:{"versions": {"azure-cli": {"local": "2.47.0"}, "core": {"local": "2.47.0"}, "telemetry": {"local": "1.0.8"}}, "update_time": "2023-04-11 17:30:11.402751", "check_time": "2023-03-22 18:05:23.331052"}PS:
I think
az upgradecauses more issues than it resolves.__main__.pycomplicated.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.