{RDBMS} decouple mysql flexible server from rdbms #26531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honghr
requested review from
DaeunYim,
calvinhzy,
evelyn-ys,
jiasli,
jsntcy and
kairu-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
requested a review
from 
ghost
added
the
Collaborator
|
RDBMS |
Contributor
Author
|
Hi @evelyn-ys, I added postgre cli owner @ambrahma as reviewer. Please wait for him to complete review before merge. |
ambrahma
suggested changes
Jun 1, 2023
src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py
Show resolved
Hide resolved
ambrahma
reviewed
Jun 2, 2023
src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py
Show resolved
Hide resolved
ambrahma
reviewed
Jun 2, 2023
src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py
Show resolved
Hide resolved
ambrahma
previously approved these changes
Jun 2, 2023
evelyn-ys
reviewed
Jun 5, 2023
evelyn-ys
reviewed
Jun 5, 2023
evelyn-ys
approved these changes
Jun 5, 2023
evelyn-ys
changed the title
kairu-ms
approved these changes
Jun 5, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
* mysql module initialize * add common comands * add mysql custom code * add unit test for mysql * remove mysql flexible server from rdbms * update setup.py to fix package load error * import mysql help doc * revert geo_redundant_backup for byok test case * insert in alphabetical order
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to facilitate development and maintenance, the source code of mysql flexible server is separated from rdbms, and postgre and mysql are decouple.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.