[Compute] az vmss deallocate: Add --hibernate parameter to support hibernating a VM while deallocating#27106
Merged
Merged
Conversation
# Conflicts: # src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vmss_update.yaml # src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py
ReaNAiveD
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vmss deallocate | cmd vmss deallocate added parameter hibernate |
ghost
requested a review
from 
ghost
added
the
Collaborator
|
Compute |
microsoft-github-policy-service
Bot
added
the
Compute
zhoxing-ms
reviewed
Aug 8, 2023
zhoxing-ms
reviewed
Aug 8, 2023
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
zhoxing-ms
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vmss deallocate --hibernateDescription
Resolve #26938
Add support for hibernating a VM while deallocating.
Because the feature is only added in the
VirtualMachineScaleSetsOperations.begin_deallocatemethod in Python SDK, but not inVirtualMachineScaleSetVMsOperations.begin_deallocatemethod. I add a walkaround incustom.py#deallocate_vmssmethod.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.