[container app] Fix #28226: az containerapp job update: Update existing scale rules if --scale-rule-name is passed#28408
Merged
zhoxing-ms merged 6 commits intoAzure:devfrom Feb 22, 2024
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @anandanthony, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Greedygre
reviewed
Feb 20, 2024
anandanthony
changed the title
anandanthony
changed the title
anandanthony
changed the title
az containerapp job update should update existing scale rules if -scale-rule-name is passed
vinisoto
approved these changes
Feb 21, 2024
Greedygre
approved these changes
Feb 21, 2024
Greedygre
reviewed
Feb 21, 2024
Contributor
|
Hi @anandanthony |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
In the test - |
Greedygre
approved these changes
Feb 22, 2024
zhoxing-ms
changed the title
az containerapp job update should update existing scale rules if -scale-rule-name is passedaz containerapp job update: Update existing scale rules if --scale-rule-name is passed
zhoxing-ms
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp job updateDescription
Fix for behavior - #28226
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.