Skip to content

{RDBMS} Add MigrationRuntimeResourceId to properties of creating migration request in CLI#28695

Merged
evelyn-ys merged 9 commits intoAzure:devfrom
nasc17:nasc/privateEndpointMigration4324
Apr 22, 2024
Merged

{RDBMS} Add MigrationRuntimeResourceId to properties of creating migration request in CLI#28695
evelyn-ys merged 9 commits intoAzure:devfrom
nasc17:nasc/privateEndpointMigration4324

Conversation

@nasc17
Copy link
Copy Markdown
Member

@nasc17 nasc17 commented Apr 4, 2024

Related command
az postgres flexible-server migration create --subscription sub --resource-group testGroup --name testserver --migration-name testmigration --properties "migrationConfig.json"

Description
Introducing new optional property MigrationRuntimeResourceId that will be responsible for migrating data between source and target server in support of private endpoint migration. This property is to be defined in JSON file passed in properties argument for creating a migration

Testing Guide
Manually
Help:
image

Pass Test:
image
image

Fail Test:
'postgres' 'flexible-server' 'migration' 'create' '--subscription' 'ac0271d6-426b-4b0d-b88d-0d0e4bd693ae' '--name' 'cli-test-server-pg-flex-eastus2euapac0271d6426b4b0db8' '--migration-name' 'nasctestmigration1' '-g' 'cli-test-do-not-delete-rg-eastus2euapac0271d6426b4b0d' '--properties' 'C:\Users\nasc\migration_test.json' '--migrationRuntimeResourceId' '/subscriptions/ac0271d6-426b-4b0d-b88d-0d0e4bd693ae/resourceGroups/temp-ss-postgresql-240102-0611-760428cd/providers/Microsoft.DBforPostgreSQL/servers/testmigration-nasc1'
WARNING: Checking the existence of the resource group 'cli-test-do-not-delete-rg-eastus2euapac0271d6426b4b0d'...
WARNING: Resource group 'cli-test-do-not-delete-rg-eastus2euapac0271d6426b4b0d' exists ? : True
ERROR: Migration runtime resource ID provided should be Flexible server.

'postgres' 'flexible-server' 'migration' 'create' '--subscription' '5c5037e5-d3f1-4e7b-b3a9-f6bf94902b30' '--resource-group' 'Aditya_PM' '--name' 'test-flexible-endpoint' '--migration-name' 'nasctestmigration3' '--properties' 'C:\Users\nasc\OneDrive - Microsoft\Documents\migration_test.json' '--migrationRuntimeResourceId' '/subscriptions/5c5037e5-d3f1-4e7b-b3a9-f6bf94902b30/resourceGroups/Aditya_PM/providers/Microsoft.DBforPostgreSQL/flexibleServers/test-flexible-endpoint'
WARNING: Checking the existence of the resource group 'Aditya_PM'...
WARNING: Resource group 'Aditya_PM' exists ? : True
ERROR: Migration Runtime server is same as Target Flexible server. Please change the values accordingly.


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Apr 4, 2024

️✔️AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.11
️✔️3.9
️✔️ams
️✔️latest
️✔️3.11
️✔️3.9
️✔️apim
️✔️latest
️✔️3.11
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.11
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.11
️✔️3.9
️✔️aro
️✔️latest
️✔️3.11
️✔️3.9
️✔️backup
️✔️latest
️✔️3.11
️✔️3.9
️✔️batch
️✔️latest
️✔️3.11
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.11
️✔️3.9
️✔️billing
️✔️latest
️✔️3.11
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.11
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.11
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.11
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.11
️✔️3.9
️✔️config
️✔️latest
️✔️3.11
️✔️3.9
️✔️configure
️✔️latest
️✔️3.11
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.11
️✔️3.9
️✔️container
️✔️latest
️✔️3.11
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.11
️✔️3.9
️✔️core
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.11
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️dla
️✔️latest
️✔️3.11
️✔️3.9
️✔️dls
️✔️latest
️✔️3.11
️✔️3.9
️✔️dms
️✔️latest
️✔️3.11
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.11
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.11
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.11
️✔️3.9
️✔️find
️✔️latest
️✔️3.11
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.11
️✔️3.9
️✔️identity
️✔️latest
️✔️3.11
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️kusto
️✔️latest
️✔️3.11
️✔️3.9
️✔️lab
️✔️latest
️✔️3.11
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.11
️✔️3.9
️✔️maps
️✔️latest
️✔️3.11
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.11
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.11
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.11
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.11
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.11
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.11
️✔️3.9
️✔️profile
️✔️latest
️✔️3.11
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.11
️✔️3.9
️✔️redis
️✔️latest
️✔️3.11
️✔️3.9
️✔️relay
️✔️latest
️✔️3.11
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️role
️✔️latest
️✔️3.11
️✔️3.9
️✔️search
️✔️latest
️✔️3.11
️✔️3.9
️✔️security
️✔️latest
️✔️3.11
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.11
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.11
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.11
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.11
️✔️3.9
️✔️sql
️✔️latest
️✔️3.11
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.11
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.11
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️util
️✔️latest
️✔️3.11
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Apr 4, 2024

️✔️AzureCLI-BreakingChangeTest
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 4, 2024

RDBMS

@nasc17 nasc17 marked this pull request as ready for review April 19, 2024 14:03
@nasc17 nasc17 changed the title [RDBMS] Add migrationRuntimeResourceId to the create migration request in CLI [RDBMS] Add MigrationRuntimeResourceId to properties of creating migration request in CLI Apr 22, 2024
@evelyn-ys evelyn-ys merged commit 0f5e68d into Azure:dev Apr 22, 2024
nasc17 added a commit to nasc17/azure-cli that referenced this pull request Apr 23, 2024
@evelyn-ys evelyn-ys changed the title [RDBMS] Add MigrationRuntimeResourceId to properties of creating migration request in CLI {RDBMS} Add MigrationRuntimeResourceId to properties of creating migration request in CLI Apr 23, 2024
evelyn-ys pushed a commit that referenced this pull request Apr 23, 2024
…ting migration request in CLI (#28804)

* Revert "[RDBMS] Add MigrationRuntimeResourceId to properties of creating migration request in CLI (#28695)"

This reverts commit 0f5e68d.

* Trigger Build

* keep comma fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants