[Batch] upgrade azure batch API version to 2024-02-01#28784
[Batch] upgrade azure batch API version to 2024-02-01#28784zhoxing-ms merged 10 commits intoAzure:devfrom
Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
|
Hi @wanghoppe, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| batch pool create | cmd batch pool create added parameter disable_automatic_rollback |
||
| batch pool create | cmd batch pool create added parameter enable_automatic_os_upgrade |
||
| batch pool create | cmd batch pool create added parameter enable_cross_zone_upgrade |
||
| batch pool create | cmd batch pool create added parameter max_batch_instance_percent |
||
| batch pool create | cmd batch pool create added parameter max_unhealthy_instance_percent |
||
| batch pool create | cmd batch pool create added parameter max_unhealthy_upgraded_instance_percent |
||
| batch pool create | cmd batch pool create added parameter mode |
||
| batch pool create | cmd batch pool create added parameter os_rolling_upgrade_deferral |
||
| batch pool create | cmd batch pool create added parameter pause_time_between_batches |
||
| batch pool create | cmd batch pool create added parameter prioritize_unhealthy_instances |
||
| batch pool create | cmd batch pool create added parameter rollback_failed_instances_on_policy_breach |
||
| batch pool create | cmd batch pool create added parameter use_rolling_upgrade_policy |
|
Batch |
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
|
Hi @zhoxing-ms, I saw you are the first assigned reviewers, and we'd like to include this change in the current milestone, could you review it as soon as possible? Thanks! |
|
Commenter does not have sufficient privileges for PR 28784 in repo Azure/azure-cli |
Please refer to this guideline guideline_link to improve the |
| c.argument('disable_automatic_rollback', options_list=['--disable-auto-rollback'], arg_type=get_three_state_flag()) | ||
| c.argument('enable_automatic_os_upgrade', options_list=['--enable-auto-os-upgrade'], arg_type=get_three_state_flag()) | ||
| c.argument('os_rolling_upgrade_deferral', options_list=['--defer-os-rolling-upgrade'], arg_type=get_three_state_flag()) | ||
| c.argument('use_rolling_upgrade_policy', arg_type=get_three_state_flag()) | ||
| c.argument('enable_cross_zone_upgrade', arg_type=get_three_state_flag()) | ||
| c.argument('prioritize_unhealthy_instances', arg_type=get_three_state_flag()) | ||
| c.argument('rollback_failed_instances_on_policy_breach', arg_type=get_three_state_flag()) |
There was a problem hiding this comment.
Why don't you add help messages for these new parameters?
There was a problem hiding this comment.
I find those arguments have default help message from our python SDK which are already good enough so omitting here.
I capitalized the "Add" keywords according to the guide, not sure is there anything else needs to be changed? |
|
@wanghoppe No, what I mean is that you need to clearly describe each change in the PR description one by one, so that customers can understand the specific functions of these changes. For example: |
zhoxing-ms
modified the milestones:
May 2024 (2024-05-21)❗ Breaking change release ❗,
April 2024 (2024-04-30)
|
@wanghoppe Currently we are working on dropping all dependencies on Can you help remove |
6 participants
Related command
Description
Upgrade azure batch API version to 2024-02-01
Upgrade
azure-batchto 14.2.0Upgrade
azure-mgmt-batchto 17.3.0Testing Guide
History Notes
[Batch]
az batch pool createAdd--upgrade-policy-modeargument to support automatic OS upgrade[Batch]
az batch pool createAdd--enable-auto-os-upgradeargument to enable automatic OS upgrade[Batch]
az batch pool createAdd--disable-auto-rollbackargument to disable OS image rollback feature[Batch]
az batch pool createAdd--defer-os-rolling-upgradeargument to defer OS upgrades on the TVMs if they are running tasks[Batch]
az batch pool createAdd--use-rolling-upgrade-policyargument to support OS rolling upgrade policy[Batch]
az batch pool createAdd--enable-cross-zone-upgradeargument to support cross zone OS upgrade[Batch]
az batch pool createAdd--max-batch-instance-percentargument to set the maximum percent of total VMs that will be upgraded in one batch[Batch]
az batch pool createAdd--max-unhealthy-instance-percentargument to set the maximum percentage of the total VMs can be simultaneously unhealthy[Batch]
az batch pool createAdd--max-unhealthy-upgraded-instance-percentargument to set the maximum percentage of upgraded VMs that can be found to be in an unhealthy state[Batch]
az batch pool createAdd--pause-time-between-batchesargument to set the wait time between batches in rolling OS upgrade[Batch]
az batch pool createAdd--prioritize-unhealthy-instancesargument to support upgrade all unhealthy VMs first[Batch]
az batch pool createAdd--rollback-failed-instances-on-policy-breachargument to enable rollback failed instances to previous model if the Rolling Upgrade policy is violatedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.