{Pylint} Fix redundant-u-string-prefix #30325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombrella
requested review from
AllyW,
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
atombrella
changed the title
microsoft-github-policy-service
bot
added
the
customer-reported
Contributor
|
Thank you for your contribution atombrella! We will review the pull request and get back to you soon. |
jiasli
reviewed
Nov 13, 2024
| return data | ||
| except NameError: | ||
| return str(data) | ||
| return str(data) |
Member
There was a problem hiding this comment.
Isn't data already a str per L925? @evelyn-ys
Suggested change
| return str(data) | |
| return data |
Member
There was a problem hiding this comment.
I actually fully copied all the files from SDK, not sure why here's a str(), but I prefer not modifying files under vendored_sdks. BTW, this azure-keyvault-securitydomain vendored sdk will be removed after SDK team publish to pypi
jiasli
reviewed
Nov 13, 2024
|
|
||
| param_file_order = ["[u'secureParam', u'boolParam', u'enumParam', u'arrayParam', u'objectParam']", | ||
| "['secureParam', 'boolParam', 'enumParam', 'arrayParam', 'objectParam']"] | ||
| param_file_order = ["['secureParam', 'boolParam', 'enumParam', 'arrayParam', 'objectParam']"] |
Member
There was a problem hiding this comment.
There is no need to put "['secureParam', 'boolParam', 'enumParam', 'arrayParam', 'objectParam']" in a list anymore.
L330 should also use
self.assertTrue(str(list(results.keys())) == param_file_order)
jiasli
previously approved these changes
Nov 13, 2024
Member
jiasli
left a comment
jiasli
left a comment
There was a problem hiding this comment.
I left some comments, but they require code logic change, which is out of the scope of this PR.
12 tasks
bebound
changed the title
necusjz
previously approved these changes
Nov 15, 2024
evelyn-ys
previously approved these changes
Nov 15, 2024
jiasli
changed the title
kairu-ms
previously approved these changes
Nov 20, 2024
atombrella
force-pushed
the
feature/no_u_prefix_lint
branch
from
29f81eb to
2038011
Compare
Contributor
Author
|
@evelyn-ys @necusjz @jiasli Could you please have another look at this? There are issues with the test runs. I think it's ready to be merged. |
Contributor
Author
kairu-ms
approved these changes
Nov 26, 2024
evelyn-ys
approved these changes
Nov 26, 2024
wangzelin007
approved these changes
Nov 27, 2024
bebound
approved these changes
Nov 27, 2024
zhoxing-ms
approved these changes
Nov 27, 2024
calvinhzy
approved these changes
Nov 28, 2024
yanzhudd
approved these changes
Nov 28, 2024
jiasli
approved these changes
Nov 28, 2024
Member
|
@atombrella, Thank you very much for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another bit of legacy from the past Python 2 days. #20192 deactivated the particular u-prefix linter.
There are several instances of Python 2 import-guards. I fixed a couple of them in affected files. Maybe those are unaffected. As far as I can see, Python 3.5 is a minimum requirement.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.