[Container] az container exec: Fix exception when stdin is not a tty
#30397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduction steps:
az container exec \
--container-name "container" \
-g "$RESOURCE_GROUP" \
-n "$ACI_NAME" \
--exec-command "echo Hello" > ./stdout < /dev/null 2>./stderr
Expected behavior:
./stdout should contain "Hello"
Actual behavior:
Command crashes without running the command. Error:
ERROR: The command failed with an unexpected error. Here is the traceback:
ERROR: (25, 'Inappropriate ioctl for device')
Traceback (most recent call last):
File "/opt/az/lib/python3.12/site-packages/knack/cli.py", line 233, in invoke
cmd_result = self.invocation.execute(args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/az/lib/python3.12/site-packages/azure/cli/core/commands/__init__.py", line 666, in execute
raise ex
File "/opt/az/lib/python3.12/site-packages/azure/cli/core/commands/__init__.py", line 733, in _run_jobs_serially
results.append(self._run_job(expanded_arg, cmd_copy))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/az/lib/python3.12/site-packages/azure/cli/core/commands/__init__.py", line 703, in _run_job
result = cmd_copy(params)
^^^^^^^^^^^^^^^^
File "/opt/az/lib/python3.12/site-packages/azure/cli/core/commands/__init__.py", line 336, in __call__
return self.handler(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/az/lib/python3.12/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
return op(**command_args)
^^^^^^^^^^^^^^^^^^
File "/opt/az/lib/python3.12/site-packages/azure/cli/command_modules/container/custom.py", line 970, in container_exec
_start_exec_pipe_linux(execContainerResponse.web_socket_uri, execContainerResponse.password)
File "/opt/az/lib/python3.12/site-packages/azure/cli/command_modules/container/custom.py", line 1006, in _start_exec_pipe_linux
old_tty = termios.tcgetattr(stdin_fd)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
termios.error: (25, 'Inappropriate ioctl for device')
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
This makes the "exec" command unusable in e.g. CI environments.
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yanzhudd and
zhoxing-ms
zhoxing-ms
approved these changes
Nov 28, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
changed the title
az container exec: fix exception when stdin is not a tty
Contributor
|
Could you add some tests for this code change? |
micromaomao
changed the title
az container exec: fix exception when stdin is not a ttyaz container exec: Fix exception when stdin is not a tty
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
Hi @zhoxing-ms - there is already a test for the Apologies for the late reply - just didn't manage to find time to look into this and eventually forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction steps:
Expected behavior:
./stdout should contain "Hello"
Actual behavior:
Command crashes without running the command. Error:
This makes the "exec" command unusable in e.g. CI environments.
Tested that all of the following works:
az container execnormally, starting bash, startingviand it takes the correct terminal size.az container execin our CI now worksThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.