[Backup] az backup restore restore-disks: Support NoZone as a valid target zone for --target-zone parameter
#30720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @SourabhSomnathGholap, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| backup restore restore-disks | cmd backup restore restore-disks update parameter target_zone: updated property choices from ['1', '2', '3'] to ['1', '2', '3', 'NoZone'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
zubairabid
approved these changes
Jan 27, 2025
Contributor
zubairabid
left a comment
zubairabid
left a comment
There was a problem hiding this comment.
Looks good, just have some clarifying questions otherwise.
src/azure-cli/azure/cli/command_modules/backup/tests/latest/test_backup_commands.py
Show resolved
Hide resolved
zhoxing-ms
changed the title
az backup restore restore-disks: Support NoZone as a valid target zone for --target-zone parameter
zhoxing-ms
approved these changes
Feb 21, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
… target zone for `--target-zone` parameter (Azure#30720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
'az backup restore restore-disks'
Description
In this PR I have added NoZone as a valid target-zone in 'az backup restore restore-disks'. Earlier valid target zones were 1,2 and 3.
Additionally, I have made code changes to support cross-zonal restore from snapshot and vault standard RP.
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.