[Service Connector] az webapp connection create fabric-sql: Fix interactive mode & allow new parameters --fabric-workspace-uuid and fabric-sql-db-uuid
#30881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @Tonychen0227, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp connection create fabric-sql | cmd containerapp connection create fabric-sql added parameter fabric_sql_db_uuid |
||
| containerapp connection create fabric-sql | cmd containerapp connection create fabric-sql added parameter fabric_workspace_uuid |
||
| functionapp connection create fabric-sql | cmd functionapp connection create fabric-sql added parameter fabric_sql_db_uuid |
||
| functionapp connection create fabric-sql | cmd functionapp connection create fabric-sql added parameter fabric_workspace_uuid |
||
| webapp connection create fabric-sql | cmd webapp connection create fabric-sql added parameter fabric_sql_db_uuid |
||
| webapp connection create fabric-sql | cmd webapp connection create fabric-sql added parameter fabric_workspace_uuid |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
xfz11
suggested changes
Feb 25, 2025
src/azure-cli/azure/cli/command_modules/serviceconnector/_validators.py
Outdated
Show resolved
Hide resolved
xfz11
reviewed
Feb 25, 2025
added 2 commits
February 25, 2025 13:48
xfz11
approved these changes
Feb 25, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Tonychen0227
changed the title
az webapp connection create fabric-sql - Fix interactive mode & allow new parameters --fabric-workspace-uuid and fabric-sql-db-uuid
Tonychen0227
changed the title
az webapp connection create fabric-sql - Fix interactive mode & allow new parameters --fabric-workspace-uuid and fabric-sql-db-uuidaz webapp connection create fabric-sql: Fix interactive mode & allow new parameters --fabric-workspace-uuid and fabric-sql-db-uuid
kairu-ms
approved these changes
Feb 25, 2025
Contributor
Author
|
All checks passed - @kairu-ms could you please merge when possible? Thanks! |
Contributor
Author
|
@yanzhudd @ReaNAiveD - ping for merge in time for https://github.com/Azure/azure-cli/milestone/152, if possible - azp run is healthy and approvals met |
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
…eractive mode & allow new parameters `--fabric-workspace-uuid` and `fabric-sql-db-uuid` (Azure#30881) * Full solution with test success * Small fix * Remove unnecessary custom changes * Recording * Fix comment out unit test * Add app config id fix * add back custom.py changes * Review comments * style style --------- Co-authored-by: Tony Chen (DevDiv) <chentony@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.