Conversation
Add to ignore
This reverts commit ee1192c.
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
nachoalonsoportillo
suggested changes
Mar 5, 2025
Member
nachoalonsoportillo
left a comment
nachoalonsoportillo
left a comment
There was a problem hiding this comment.
This PR isn't required. Current implementation aligns with what backend enforces.
Member
Author
PR has been updated after our offline conversation. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
evelyn-ys
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server updateDescription
Issue discovered with updating the geo-backup user identity and Key Vault key for data encryption on their Azure PostgreSQL flexible server. Using the command does not reflect changes, even though no errors are returned.
Code was incorrectly not passing in geo-backup user identity and Key Vault key to the data encryption property.
Also, in order for this to work, primary user identity and Key Vault key need to be passed. Check for users current settings to pass if not provided.
Add validator for if backup user identity and backup identity are not the same.
Testing Guide
Manual
Validation check:
History Notes
[RDBMS]
az postgres flexible-server update: Fix bug for not updating geo backup data encryption propertiesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.