{CI} Continue on Error for SBOM task#31652
Merged
wangzelin007 merged 1 commit intoAzure:devfrom Jun 16, 2025
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Pipelines configuration to allow SBOM manifest-generator tasks to continue on error, preventing pipeline failures if SBOM generation fails.
- Added
continueOnError: trueunder each SBOM manifest-generation task inazure-pipelines.yml.
Comments suppressed due to low confidence (2)
azure-pipelines.yml:229
- The indentation of
continueOnErrordoes not match the surrounding keys (displayNameandinputs) and will likely cause a YAML parsing error. It should be indented to align withdisplayName(e.g., 6 spaces).
continueOnError: true
azure-pipelines.yml:229
- [nitpick] You're repeating the same
continueOnError: truesetting in seven places. Consider extracting the SBOM task into a template or job variable to reduce duplication and ease future updates.
continueOnError: true
bebound
approved these changes
Jun 13, 2025
evelyn-ys
approved these changes
Jun 16, 2025
necusjz
approved these changes
Jun 16, 2025
3 tasks
jiasli
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
continueOnError: trueto the SBOM task in the pipeline to prevent CI failures when SBOM generation encounters issues.Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.