[Containerapp] az containerapp job create: Fix issues for help message
#31682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greedygre
requested review from
Juliehzl,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Greedygre, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes and enhances the az containerapp job create help examples to correct metadata syntax and include the required --environment parameter.
- Updated
--scale-rule-metadataexamples to usekey=valuesyntax instead of JSON-style strings. - Added the
--environmentflag to all job create examples (Manual, Schedule, Event). - Corrected the sample
--scale-rule-namevalue for consistency.
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/containerapp/_help.py:645
- [nitpick] The example uses
--scale-rule-name queue, which may be too generic. Consider using a more descriptive name (e.g.,queue_job) to clearly convey its purpose and remain consistent with other examples.
--scale-rule-name queue \\
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007 and
yonzhan
ShichaoQiu
approved these changes
Jun 20, 2025
chinadragon0515
approved these changes
Jun 20, 2025
zhoxing-ms
approved these changes
Jun 20, 2025
zhoxing-ms
changed the title
az containerapp job create: Fix message with --helpaz containerapp job create: Fix issues for help message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.