Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the az postgres flexible-server update command that prevented enabling high availability for PostgreSQL 11 and 12 servers due to a missing configuration check.
- Adds version check to skip fabric mirroring configuration validation for PG11 and PG12 servers
- Allows high availability to be enabled for these older PostgreSQL versions that don't support fabric mirroring
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
mattboentoro
left a comment
There was a problem hiding this comment.
nit: change the title to describe that we're bypassing fabric support
az postgres flexible-server update: BUG FIX, allow enabling high availabiity for PG11 and PG12 serversaz postgres flexible-server update: BUG FIX, bypass fabric mirroring validation to allow high availability enablement for PG11 and PG12 servers
az postgres flexible-server update: BUG FIX, bypass fabric mirroring validation to allow high availability enablement for PG11 and PG12 serversaz postgres flexible-server update: BUG FIX, bypass fabric mirroring validation to allow updating high availability status for PG11 and PG12 servers
|
@evelyn-ys please trigger test run |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@evelyn-ys checks have passed and team sign off. Please review |
Related command
az postgres flexible-server updateDescription
Cannot enable HA in a pg12 server using az cli
root@westus2-stage-lmgmt-1:~# az postgres flexible-server update --name westus2-stage-postgresql --resource-group anf.dc.mgmt.westus2-stage.rg --high-availability ZoneRedundant
(ConfigurationNotExists) The configuration 'azure.fabric_mirror_enabled' does not exist for westus2-stage-postgresql server version 12.
Code: ConfigurationNotExists
Message: The configuration 'azure.fabric_mirror_enabled' does not exist for westus2-stage-postgresql server version 12.
Skip this check for PG11 and PG12 servers
Testing Guide
Manual
History Notes
[RDBMS]
az postgres flexible-server update: BUG FIX, bypass fabric mirroring validation to allow updating high availability status for PG11 and PG12 servers