-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[RDBMS] az postgres flexible-server create/update/restore: Premium SSD V2 is no longer supported with Burstable compute tier
#31948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR blocks the use of Premium SSD V2 storage type with Burstable compute tier for PostgreSQL flexible servers, as this combination is no longer supported.
- Added validation to prevent Premium SSD V2 usage with Burstable tier in create, update, and restore operations
- Enhanced the existing storage type validator with tier validation
- Added a dedicated restore validator for handling the specific case of restoring with Premium SSD V2
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| validators.py | Added tier parameter to storage validator and new restore validator to block Burstable + Premium SSD V2 |
| flexible_server_custom_postgres.py | Integrated the restore validator into the restore operation flow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| def pg_restore_validator(compute_tier, **args): | ||
| is_ssdv2_enabled = args.get('storage_type', None) == "PremiumV2_LRS" | ||
|
|
||
| if is_ssdv2_enabled and compute_tier.lower() == 'burstable': |
Copilot
AI
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function does not handle the case where compute_tier might be None or empty. This could cause an AttributeError when calling .lower() on a None value.
| if is_ssdv2_enabled and compute_tier.lower() == 'burstable': | |
| if is_ssdv2_enabled and compute_tier and compute_tier.lower() == 'burstable': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good suggestion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az postgres flexible-server create/update/restoreDescription
Premium SSD V2 will now be blocked with Burstable compute tier. This is being reflected in API response not showing as supported.
Testing Guide
Manually
History Notes
[RDBMS]
az postgres flexible-server create/update/restore: Premium SSD V2 is no longer supported with Burstable compute tier