[Compute] az vm disk attach: Add new parameter --new-names-of-source-snapshots-or-disks to support setting the name of create new disk from a snapshot or another disk
#32172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jing-song
requested review from
jsntcy,
wangzelin007 and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm disk attach | cmd vm disk attach added parameter new_names_of_source_disk_restore_point |
||
| vm disk attach | cmd vm disk attach added parameter new_names_of_source_snapshots_or_disks |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for naming new disks when creating them from snapshots, existing disks, or disk restore points in the az vm disk attach command.
- Add two new optional parameters to specify custom names for newly created disks
- Implement validation logic to ensure proper parameter usage and count matching
- Update test coverage to verify the new functionality and error handling
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| _params.py | Adds the two new command-line parameters with help text |
| _validators.py | Implements validation logic for the new parameters |
| custom.py | Updates disk attachment logic to use custom names when provided |
| test_vm_commands.py | Adds test cases for the new parameters and error scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+551
to
+552
| c.argument('new_names_of_source_snapshots_or_disks', options_list=['--new-names-of-source-snapshots-or-disks', '--new-names-of-sr'], nargs='+', min_api='2024-11-01', help='The name of create new data disk from a snapshot or another disk.') | ||
| c.argument('new_names_of_source_disk_restore_point', options_list=['--new-names-of-source-disk-restore-point', '--new-names-of-rp'], nargs='+', min_api='2024-11-01', help='The name of create new data disk from a disk restore point.') |
There was a problem hiding this comment.
The help messages should start with verbs in active voice. Change 'The name of create new data disk' to 'Name the new data disk' for both parameters.
Comment on lines
+1896
to
+1899
| raise RequiredArgumentMissingError("Please use --source-snapshots-or-disks when using" | ||
| " --new-names-of-source-snapshots-or-disks") | ||
| if namespace.new_names_of_source_disk_restore_point and not namespace.source_disk_restore_point: | ||
| raise RequiredArgumentMissingError("Please use --source-disk-restore-point when using" |
There was a problem hiding this comment.
The error messages reference incorrect parameter names. Line 1896 should reference --source-resource (the shorter alias), and line 1899 should reference --source-disk-rp to match the test expectations and actual parameter aliases.
Suggested change
| raise RequiredArgumentMissingError("Please use --source-snapshots-or-disks when using" | |
| " --new-names-of-source-snapshots-or-disks") | |
| if namespace.new_names_of_source_disk_restore_point and not namespace.source_disk_restore_point: | |
| raise RequiredArgumentMissingError("Please use --source-disk-restore-point when using" | |
| raise RequiredArgumentMissingError("Please use --source-resource when using" | |
| " --new-names-of-source-snapshots-or-disks") | |
| if namespace.new_names_of_source_disk_restore_point and not namespace.source_disk_restore_point: | |
| raise RequiredArgumentMissingError("Please use --source-disk-rp when using" |
zhoxing-ms
approved these changes
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm disk attachDescription
Support setting the name of create new disk from a snapshot or another disk or disk restore point.
Testing Guide
History Notes
[Compute]
az vm disk attach: Add new parameter--new-names-of-source-snapshots-or-disksto support setting the name of create new disk from a snapshot or another disk[Compute]
az vm disk attach: Add new parameter--new-names-of-source-disk-restore-pointto support setting the name of create new disk from a disk restore pointThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.