-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Misc.} Add devcontainer environment variables #32195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @necusjz, |
️✔️AzureCLI-BreakingChangeTest
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the aaz-dev launch command in the devcontainer environment by adding environment variables to configure the required paths automatically, eliminating the need for manual command-line parameters.
Key changes:
- Added environment variables configuration for aaz-dev tool paths
- Simplified launch instructions by removing explicit path parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .devcontainer/.env | New file defining environment variables for aaz-dev tool paths |
| .devcontainer/devcontainer.json | Added runArgs to load environment variables from .env file |
| .devcontainer/init.sh | Updated launch instructions to use simplified aaz-dev run command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Related command
Description
simplify the launch command of aaz (mcp server can also leverage them).
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.