-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Codespaces} Skip login in non-interactive shells #32250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Can you please explain the reasoning for this change? To clarify, is it because login fails in non-interactive shells? |
the case shows in the description. the root cause i assume is when gh runs in a non-interactive environment or when its output is redirected, it “leaks” to the screen, resulting in the garbled text. (wip on testing, that's why the pr maked as "draft") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the Codespaces initialization script to skip GitHub authentication prompts in non-interactive shell sessions. The change prevents authentication dialogs from appearing when the script runs in automated or non-interactive environments.
- Wraps GitHub authentication logic in an interactive shell check
- Prevents unwanted authentication prompts in non-interactive sessions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Related command
Description
always display
11;rgb:f6f6/f8f8/fafa;1R11;rgb:f6f6/f8f8/fafa;1Rafter setup.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.