-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Batch} Pin azure-batch in setup.py #32279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR pins the azure-batch dependency to version 15.0.0b1 in response to compatibility issues introduced in version 15.0.0b3. The newer version renamed model classes (e.g., AffinityInfo → BatchAffinityInfo), breaking imports in the batch command module.
Key Changes:
- Changed
azure-batchversion specifier from~=15.0.0b1(allowing compatible releases) to==15.0.0b1(exact pin)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
azure-batchreleased new version 15.0.0b3, which is not compatible with previous version.When install azure-cli from PyPI, Integration Test against Profiles Python312 failed with this error:
Pin the version to
15.0.0b1, matching requirements.txt.Related PR: #30501
Ref: https://dev.azure.com/azclitools/public/_build/results?buildId=276835&view=logs&jobId=918eca13-e87f-5234-76ca-b0a0c5383642&j=918eca13-e87f-5234-76ca-b0a0c5383642&t=7158aeab-8c89-5857-4851-ee2901405347