[backup] az backup vault deleted-vault: Implementing List and Undelete for Deleted Backup Vaults
#32306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @zubairabid, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
Contributor
Author
|
Targeting November release (2025-11-04) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements list, get, undelete, and list-containers commands for soft-deleted Recovery Services vaults in Azure Backup, targeting the November 2025 release.
Key Changes:
- Upgrades
azure-mgmt-recoveryservicesfrom version 3.1.0 to 4.0.0 to support deleted vault operations - Adds four new commands under
az backup deleted-vault: list, get, undelete, and list-containers - Implements helper functions for extracting resource parameters from deleted vault IDs
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updated azure-mgmt-recoveryservices dependency from ~=3.1.0 to ~=4.0.0 |
| requirements.py3.windows.txt | Updated azure-mgmt-recoveryservices from 3.1.0 to 4.0.0 |
| requirements.py3.Linux.txt | Updated azure-mgmt-recoveryservices from 3.1.0 to 4.0.0 |
| requirements.py3.Darwin.txt | Updated azure-mgmt-recoveryservices from 3.1.0 to 4.0.0 |
| custom_help.py | Added helper functions for parsing deleted vault IDs and extracting resource group information |
| custom.py | Implemented list, get, undelete, and list-containers operations for deleted vaults |
| commands.py | Registered new deleted-vault command group with four subcommands |
| _params.py | Added parameter definitions for deleted vault commands; removed unused parameter |
| _help.py | Added help documentation and examples for all deleted-vault commands |
| _client_factory.py | Added deleted_vaults_cf factory function for deleted vaults client |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…zubairabid/azure-cli into users/zubair/RSVVaultSoftDelete
…zubairabid/azure-cli into users/zubair/RSVVaultSoftDelete
…zubairabid/azure-cli into users/zubair/RSVVaultSoftDelete
…zubairabid/azure-cli into users/zubair/RSVVaultSoftDelete
zhoxing-ms
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Targeting November release (2025-11-04).
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.