{Network} AppGateway Setting and Probe support Client IP Preservation properties #32442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william051200
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @william051200, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network application-gateway probe create | cmd network application-gateway probe create added parameter enable_proxy_header |
||
| network application-gateway probe update | cmd network application-gateway probe update added parameter enable_proxy_header |
||
| network application-gateway settings create | cmd network application-gateway settings create added parameter enable_l4_client_ip |
||
| network application-gateway settings update | cmd network application-gateway settings update added parameter enable_l4_client_ip |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for two new client IP preservation properties to Azure Application Gateway commands:
enableL4ClientIpPreservationfor backend settingsenableProbeProxyProtocolHeaderfor health probes
Key Changes:
- Added
--enable-l4-client-ip-preservationparameter to settings commands (create/update) - Added
--enable-probe-proxy-protocol-headerparameter to probe commands (create/update) - Updated API version from
2023-11-01to2025-01-01across all affected command files - Added comprehensive test coverage for both new properties
Reviewed Changes
Copilot reviewed 20 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_network_commands.py | Added two new test methods to verify the new properties work correctly |
| settings/_create.py | Added enableL4ClientIpPreservation argument and schema support |
| settings/_update.py | Added enableL4ClientIpPreservation argument and schema support |
| settings/_show.py | Updated schema to include enableL4ClientIpPreservation property |
| settings/_list.py | Updated schema to include enableL4ClientIpPreservation property |
| settings/_delete.py | Updated schema to include enableL4ClientIpPreservation property |
| settings/_wait.py | Updated schema to include enableL4ClientIpPreservation property |
| probe/_create.py | Added enableProbeProxyProtocolHeader argument and schema support |
| probe/_update.py | Added enableProbeProxyProtocolHeader argument and schema support |
| probe/_show.py | Updated schema to include enableProbeProxyProtocolHeader property |
| probe/_list.py | Updated schema to include enableProbeProxyProtocolHeader property |
| probe/_delete.py | Updated schema to include enableProbeProxyProtocolHeader property |
| probe/_wait.py | Updated schema to include enableProbeProxyProtocolHeader property |
| Various __cmd_group.py files | Code cleanup: removed outdated comments and added trailing commas |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
from https://dev.azure.com/azclitools/public/public%20Team/_build/results?buildId=283936&view=logs&j=168ccbe3-da49-5c0b-6478-08f7016e4bf5&t=10a595be-4223-5cc7-9a73-012871b6eaee&l=191, let's come up with some shorter aliases for the new parameters. |
Member
|
insert multiple changelogs into "History Notes" section is good. however, we'd better to describe things from the user’s perspective, so it can be optimized as, |
necusjz
reviewed
Nov 21, 2025
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Show resolved
Hide resolved
necusjz
reviewed
Nov 21, 2025
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
necusjz
reviewed
Nov 24, 2025
...azure/cli/command_modules/network/aaz/latest/network/application_gateway/settings/_update.py
Show resolved
Hide resolved
necusjz
reviewed
Nov 24, 2025
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
william051200
requested review from
FumingZhang,
yanzhudd and
zhoxing-ms
as code owners
Member
|
it seems we need to git rebase a little bit to make our changes clean, |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
william051200
force-pushed
the
32366-new-property
branch
from
e333e5e to
0d53331
Compare
necusjz
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az network application-gateway settings createaz network application-gateway settings showaz network application-gateway settings updateaz network application-gateway probe createaz network application-gateway probe showaz network application-gateway probe updateDescription
Resolve #32366
aaz Azure/aaz#905
Testing Guide
Settings: To create settings with value enableL4ClientIpPreservation as false by default
az network application-gateway settings createSettings: To update settings enableL4ClientIpPreservation property value to True
az network application-gateway settings update --enable-l4-client-ip-preservation trueProbe: To create probe with value enableProbeProxyProtocolHeader false by default
az network application-gateway probe createSettings: To update settings enableProbeProxyProtocolHeader value to True
az network application-gateway probe update --enable-probe-proxy-protocol-header trueHistory Notes
[Network]
az network application-gateway settings: SupportenableL4ClientIpPreservationproperty via--enable-l4-client-ip[Network]
az network application-gateway probe: SupportenableProbeProxyProtocolHeaderproperty via--enable-proxy-headerThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.