{MySQL} az mysql flexible-server backup delete: Support deletion of on-demand backup
#32498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| mysql flexible-server backup delete | cmd mysql flexible-server backup delete added |
||
| mysql flexible-server backup show | cmd mysql flexible-server backup show update parameter backup_name: removed property id_part=child_name_1 |
||
| mysql flexible-server backup show | cmd mysql flexible-server backup show update parameter server_name: removed property id_part=name |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for deleting on-demand backups in Azure MySQL flexible servers through the CLI. The implementation updates the Azure MySQL flexible servers SDK to version 1.1.0b1 to enable this functionality.
Key Changes:
- Added new
az mysql flexible-server backup deletecommand - Updated
azure-mgmt-mysqlflexibleserverspackage from version 1.0.0b3 to 1.1.0b1 - Modified backup show command parameter configuration to remove resource ID parsing support
Reviewed changes
Copilot reviewed 9 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updated azure-mgmt-mysqlflexibleservers dependency to 1.1.0b1 |
| src/azure-cli/requirements.py3.windows.txt | Updated azure-mgmt-mysqlflexibleservers dependency for Windows |
| src/azure-cli/requirements.py3.Linux.txt | Updated azure-mgmt-mysqlflexibleservers dependency for Linux |
| src/azure-cli/requirements.py3.Darwin.txt | Updated azure-mgmt-mysqlflexibleservers dependency for macOS |
| src/azure-cli/azure/cli/command_modules/mysql/commands.py | Added backup delete command registration |
| src/azure-cli/azure/cli/command_modules/mysql/_params.py | Added parameters for backup delete command and modified backup show parameters |
| src/azure-cli/azure/cli/command_modules/mysql/_help.py | Added help documentation for backup delete command |
| src/azure-cli/azure/cli/command_modules/mysql/tests/latest/test_mysql_scenario.py | Various test updates including SKU changes, location changes, and refactored test assertions |
| src/azure-cli/azure/cli/command_modules/mysql/tests/latest/recordings/test_mysql_flexible_server_maintenance_mgmt.yaml | Updated test recording with new API version and maintenance dates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| c.argument('backup_name', id_part='child_name_1', options_list=['--backup-name', '-b'], help='The name of the backup.') | ||
| c.argument('resource_group_name', arg_type=resource_group_name_type) | ||
| c.argument('server_name', id_part=None, arg_type=server_name_arg_type) | ||
| c.argument('backup_name', options_list=['--backup-name', '-b'], help='The name of the backup.') |
There was a problem hiding this comment.
The removal of id_part='child_name_1' from the backup_name argument may be a breaking change. This parameter was previously used to support resource ID parsing for hierarchical resources. If users were previously able to use resource IDs with the backup show command, they will no longer be able to do so. This could break existing automation scripts or workflows. Consider whether this removal is intentional and document it as a breaking change if so, or restore the id_part parameter to maintain backward compatibility.
Suggested change
| c.argument('backup_name', options_list=['--backup-name', '-b'], help='The name of the backup.') | |
| c.argument('backup_name', id_part='child_name_1', options_list=['--backup-name', '-b'], help='The name of the backup.') |
| with self.command_group('mysql flexible-server backup', mysql_flexible_long_running_backup_sdk, | ||
| client_factory=cf_mysql_flexible_backup) as g: | ||
| g.command('create', 'begin_create') | ||
| g.command('delete', 'begin_delete') |
There was a problem hiding this comment.
The new backup delete command lacks test coverage. The existing FlexibleServerBackupsMgmtScenarioTest test class tests backup create, backup list, and backup show, but does not include a test for the newly added backup delete command. Consider adding a test case that creates a backup and then deletes it to ensure the delete functionality works correctly.
necusjz
approved these changes
Dec 4, 2025
evelyn-ys
approved these changes
Dec 5, 2025
evelyn-ys
changed the title
az mysql flexible-server backup delete: Support deletion of on-demand backupaz mysql flexible-server backup delete: Support deletion of on-demand backup
evelyn-ys
pushed a commit
that referenced
this pull request
Dec 10, 2025
…ort deletion of on-demand backup (#32513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server backup delete
Description
Need the ability to support deletion of on-demand backup through CLI
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.